Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make gutters configurable #1967

Merged
merged 25 commits into from
Apr 16, 2022
Merged

Make gutters configurable #1967

merged 25 commits into from
Apr 16, 2022

Conversation

David-Kunz
Copy link
Contributor

@David-Kunz David-Kunz commented Apr 5, 2022 •
edited
Loading

This implements the feature request of issue #1960 (slightly adapted based on feedback from @archseer).

Now one can configure the displayed gutters with

[editor]
gutters = ["diagnostics", "line-numbers"]

(default)

Here a picture with

[editor]
gutters = ["diagnostics"]

without-line-numbers

@David-Kunz David-Kunz mentioned this pull request Apr 5, 2022
Closed
@David-Kunz David-Kunz changed the title config option to set line numbers to none config option to set line-numbers to none Apr 5, 2022
@David-Kunz David-Kunz changed the title config option to set line-numbers to none config option to set line-number to none Apr 5, 2022
@David-Kunz David-Kunz changed the title config option to set line-number to none editor option to set line-number to none Apr 5, 2022
archseer
archseer requested changes Apr 8, 2022
View reviewed changes
helix-view/src/editor.rs Outdated Show resolved Hide resolved
helix-view/src/view.rs Outdated Show resolved Hide resolved
@David-Kunz David-Kunz force-pushed the omit-line-number-gutter branch from d9d68a6 to 478744f Compare April 8, 2022 05:49
@David-Kunz David-Kunz changed the title editor option to set line-number to none Make gutters configurable Apr 8, 2022
@David-Kunz David-Kunz requested a review from archseer April 8, 2022 20:10
@the-mikedavis the-mikedavis mentioned this pull request Apr 9, 2022
Merged
archseer
archseer requested changes Apr 12, 2022
View reviewed changes
helix-view/src/editor.rs Outdated Show resolved Hide resolved
helix-view/src/editor.rs Outdated Show resolved Hide resolved
helix-view/src/view.rs Outdated Show resolved Hide resolved
@David-Kunz David-Kunz requested a review from archseer April 15, 2022 13:13
archseer
archseer approved these changes Apr 16, 2022
View reviewed changes
Copy link
Member

@archseer archseer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Looks good to merge 🎉

@archseer archseer merged commit b04c425 into helix-editor:master Apr 16, 2022
This was referenced Apr 17, 2022
Closed
Closed
@David-Kunz
Copy link
Contributor Author

David-Kunz commented Apr 18, 2022 •
edited
Loading

Thank you for your help and guidance, @archseer!

@groovy9
Copy link

groovy9 commented Apr 20, 2022

How do I change this while running? I tried several variations of the following but it throws an "bad arguments" error

:set gutters ["diagnostics"]

@groovy9 groovy9 mentioned this pull request Apr 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archseer archseer archseer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@David-Kunz @groovy9 @archseer