Add true or false checkbox in health output table #1947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archseer
reviewed
Apr 5, 2022
helix-term/src/health.rs
Outdated
Comment on lines
137
to
138
| Ok(_) => column(&format!("✔ {cmd}"), Color::Green), | ||
| Err(_) => column(&format!("✘ {cmd}"), Color::Red), |
There was a problem hiding this comment.
Please use format("... {}", cmd) so our MSRV doesn't increase. #1881
There was a problem hiding this comment.
Thank you for the feedback. I have implemented your suggestion.
hx --health output table's second and third columns were not showing symbols like ✔ or ✘ to indicate whether LSP or DAP binaries were found. This change adds these symbols to improve accessibility. Fixes helix-editor#1894 Signed-off-by: Nirmal Patel <[email protected]>
nirmal-j-patel
force-pushed
the
health_table_symbols
branch
from
391c8bf to
27b31c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hx --health output table's second and third columns were not showing
symbols like ✔ or ✘ to indicate whether LSP or DAP binaries were found.
This change adds these symbols to improve accessibility.
Fixes #1894
Signed-off-by: Nirmal Patel [email protected]