Basic support for C-r to paste register in prompt
#1924
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-Fields
force-pushed
the
1512-prompt-register
branch
from
3d41792 to
c5c8895
Compare
|
Thanks for working on this.
Like you mentioned, the infobox being drawn in the back doesn't look nice. |
pickfire
reviewed
Apr 18, 2022
Comment on lines
+456
to
+473
| if self.pending_register { | ||
| // C-r was pressed previously; this keystroke is the register | ||
| self.pending_register = false; | ||
| cx.editor.autoinfo = None; | ||
|
|
||
| if let KeyEvent { | ||
| code: KeyCode::Char(register), | ||
| modifiers: KeyModifiers::NONE, | ||
| } = event.into() | ||
| { | ||
| if let Some(text) = cx.editor.registers.get(register) { | ||
| self.insert_str(&text.read()[0]); | ||
| } | ||
| } | ||
|
|
||
| (self.callback_fn)(cx, &self.line, PromptEvent::Update); | ||
| return EventResult::Consumed(None); | ||
| } |
There was a problem hiding this comment.
This feels weird to me and if more and more states are being added it might be less maintainable, I think it might be better to have some sort of state machine (like using enum) here to make sure we can't go wrong. But maybe someone else might have a better solution for this.
But sadly we can't hook on_next_key nicely here.
the-mikedavis
added
the
S-waiting-on-author
|
Replaced by #2458 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #1512
Outstanding issues: