Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set VERSION file to dev #1883

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Conversation

the-mikedavis
Copy link
Member

Forgot to follow up on this: the idea is that we set the VERSION file to include -dev after a release so it's easy to see when someone is building from source on a non-tagged version.

@kirawi
Copy link
Member

kirawi commented Mar 30, 2022

Maybe a better solution would be using an environment var to check whether it's building in CI or not?

@the-mikedavis
Copy link
Member Author

We could probably have the CI modify the VERSION file to remove the -dev suffix (so we'd still need to update the VERSION file before a release but not before and after)

@archseer
Copy link
Member

Should we bump this to 22.05-dev?

@archseer archseer merged commit ef91b65 into helix-editor:master Mar 31, 2022
@the-mikedavis the-mikedavis deleted the md-version-dev branch March 31, 2022 15:47
@orhun
Copy link
Contributor

orhun commented May 28, 2022

Shouldn't this be set to e.g. 22.05 right before a new release? I've built helix from the last tagged release but helix -V shows 22.05-dev 🤔

@archseer
Copy link
Member

There's two ways: either bump right before a release, or do it right after. We tried doing it after a release so that builds from master have a different version from the latest stable release, but we forgot to remove the -dev suffix...

Will push a new 22.05 tag shortly!

@archseer
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants