-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add indent guides #1796
Add indent guides #1796
Conversation
Would it make sense to allow configuring which character to use as indent guide? |
d7bf39c
to
aa56992
Compare
Yup, it should also be possible to disable it altogether, I'm planning to follow this up with a configuration PR. |
Can we add this here? I find indent guides distracting so I'd turn them off by default. |
aa56992
to
73ffb0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave this a try locally and it looks great 🚀
The only thing I see that could be surprising is that the indent guides draw over tab characters if you have visible whitespace turned on. I think it makes sense for the indent guide to win in that case but we could re-think the rendering of tab in the future to offset by one column so it's visible or something similar.
Properly addressing that issue would have been easier if we were not limited to fixed width fonts. VSCode for example squeezes both the tab character and indent guide character into the same column by adjusting their sizes as required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! No complaints
Adds a theme scope
ui.virtual.indent-guide
.TODO