Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --edit-config flag to directly open config.toml #1771

Merged
merged 2 commits into from
Mar 9, 2022

Conversation

jharrilim
Copy link
Contributor

Just a nice-to-have that makes editing the config feel a bit more first class.

@sudormrfbin
Copy link
Member

How about renaming the flag to --edit-config ? --config sounds like a flag to set the path of the config file.

@jharrilim jharrilim force-pushed the feat/hx-config/jharrilim branch from e46f070 to 919bb17 Compare March 8, 2022 05:30
Add book entry

Change to --edit-config
@jharrilim jharrilim force-pushed the feat/hx-config/jharrilim branch from 919bb17 to 9ff5b58 Compare March 8, 2022 05:31
@jharrilim
Copy link
Contributor Author

How about renaming the flag to --edit-config ? --config sounds like a flag to set the path of the config file.

You're right, switched it!

Copy link
Member

@sudormrfbin sudormrfbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@sudormrfbin sudormrfbin changed the title Add --config option to hx Add --edit-config flag to directly open config.toml Mar 9, 2022
@sudormrfbin sudormrfbin merged commit 8d7a25b into helix-editor:master Mar 9, 2022
@archseer
Copy link
Member

Does this really need to be a flag? Couldn't we make it a :command, that would be more flexible since it wouldn't require you to re-open the editor.

@jharrilim
Copy link
Contributor Author

jharrilim commented Mar 10, 2022

The main reason I proposed this was so I could fiddle with configs and explicitly re-open the editor to get the newer config changes applied, so at least in my mind, a restart was actually desirable. Admittedly, I didn't dig into the code enough to figure out what changes are needed to make this a :command that would also apply the changes live. This would definitely be cool if we could do though. It would enable things like theme picking with a live preview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants