Change parameter object keybind from p to a
#1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase? Fixed lints on master |
sudormrfbin
force-pushed
the
rename-parameter-object
branch
from
dc2aaca to
d6f59fe
Compare
|
Should the docs still use "argument (parameter)" somewhere so that it is easy find in a search? |
sudormrfbin
force-pushed
the
rename-parameter-object
branch
from
d6f59fe to
5f2de72
Compare
|
Could we keep parameter and use |
|
Paragraph movement is something I use fairly a lot, and I would say the same goes for most people. |
|
How about keeping the same name for the functions and query scopes, but using The highlight scopes already use |
This is largely to avoid a collision with the soon to be merged paragraph object which takes up the p key.
sudormrfbin
force-pushed
the
rename-parameter-object
branch
from
5f2de72 to
ac51619
Compare
sudormrfbin
changed the title
p to a
archseer
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1627 requires
pfor paragraph textobject which was being used by parameter. This PR replaces parameter'spwithawhich can be thought of as "argument", and replaces all instances of "parameter" with "argument" for consistent naming.