-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kotlin language #1689
Add kotlin language #1689
Conversation
Queries taken from https://github.com/nvim-treesitter/nvim-treesitter/blob/master/queries/kotlin seem to work well enough for my needs though I don't use kotlin heavily.
You'll need to change the scopes to the ones Helix uses: https://docs.helix-editor.com/themes.html#scopes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments but this is looking pretty good otherwise, nice work! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work! 🎊
runtime/queries/kotlin/locals.scm
Outdated
@@ -0,0 +1,83 @@ | |||
;;; Imports | |||
|
|||
(package_header |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This locals definition doesn't match helix/tree-sitter, we use different scopes: https://github.com/helix-editor/helix/blob/master/runtime/queries/rust/locals.scm
It's okay to just remove locals.scm
and we can do them in a follow-up PR though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Co-authored-by: Ivan Tham <[email protected]>
Thanks! 🎉 |
Queries taken from https://github.com/nvim-treesitter/nvim-treesitter/blob/master/queries/kotlin seem to work well enough for my needs though I don't use kotlin heavily.