refactor align_selection using kakoune logic #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archseer
reviewed
Mar 2, 2022
helix-term/src/commands.rs
Outdated
| column_widths.push(vec![(l1, cursor)]); | ||
| } | ||
| } | ||
| let mut max_curs = vec![]; |
There was a problem hiding this comment.
Suggested change
| let mut max_curs = vec![]; | |
| let mut max_curs = Vec::with_capacity(column_widths.len()) |
helix-term/src/commands.rs
Outdated
Comment on lines
812
to
814
| for item in column_widths[i].iter_mut() { | ||
| pads.insert(item.0, max_cur - item.1); | ||
| } |
There was a problem hiding this comment.
Suggested change
| for item in column_widths[i].iter_mut() { | |
| pads.insert(item.0, max_cur - item.1); | |
| } | |
| for (line_start, cursor) in &column_widths[i] { | |
| pads.insert(line_start, max_cur - cursor); | |
| } |
helix-term/src/commands.rs
Outdated
| .fold(0, |max, &(_, cur)| max.max(cur)); | ||
| max_curs.push(max_cur); | ||
|
|
||
| let mut pads = std::collections::HashMap::new(); |
There was a problem hiding this comment.
Suggested change
| let mut pads = std::collections::HashMap::new(); | |
| let mut pads = std::collections::HashMap::with_capacity(column_widths[i].len()); |
helix-term/src/commands.rs
Outdated
Comment on lines
806
to
808
| let max_cur = column_widths[i] | ||
| .iter() | ||
| .fold(0, |max, &(_, cur)| max.max(cur)); |
There was a problem hiding this comment.
.iter().map(|(_, cur)| cur).max()?
|
Thanks! 🎉 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1670