Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload source with gitmodules on release #1536

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 42 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,46 @@ jobs:
name: bins-${{ matrix.build }}
path: dist

source:
name: Create Source tarball
runs-on: ubuntu-latest
steps:
- name: Checkout sources
uses: actions/checkout@v2
with:
submodules: true

- name: Install dependencies
shell: bash
run: |
sudo apt-get update -qq -y
sudo apt-get install -qq -y python3-pip python3
sudo pip3 install git-archive-all
Comment on lines +122 to +124
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the extra dependencies here. Since the submodules are already checked out it should be enough to package helix-syntax/languages/*. Let's hold off on this until we decide on #1560 though

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, for this case it should hopefully be simple enough to use tar with --exclude-vcs


- name: Calculate tag name
shell: bash
run: |
name=dev
if [[ $GITHUB_REF == refs/tags/v* ]]; then
name=${GITHUB_REF:10}
fi
echo ::set-output name=val::$name
echo TAG=$name >> $GITHUB_ENV
id: tagname

- name: Build archive
shell: bash
run: |
git-archive-all --prefix=helix-$TAG helix-$TAG.tar.gz

- uses: actions/[email protected]
with:
name: helix-source
path: helix-*.tar.gz

publish:
name: Publish
needs: [dist]
needs: [dist, source]
runs-on: ubuntu-latest
steps:
- name: Checkout sources
Expand All @@ -121,7 +158,9 @@ jobs:
# with:
# path: dist
# - run: ls -al ./dist
- run: ls -al bins-*
- run: |
ls -al bins-*
ls -la helix-source

- name: Calculate tag name
run: |
Expand Down Expand Up @@ -160,6 +199,7 @@ jobs:
(cd tmp && 7z a -r ../dist/$pkgname.zip $pkgname)
fi
done
mv helix-source/helix-$TAG.tar.gz dist/

- name: Upload binaries to release
uses: svenstaro/upload-release-action@v2
Expand Down