-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload source with gitmodules on release #1536
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -107,9 +107,46 @@ jobs: | |
name: bins-${{ matrix.build }} | ||
path: dist | ||
|
||
source: | ||
name: Create Source tarball | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout sources | ||
uses: actions/checkout@v2 | ||
with: | ||
submodules: true | ||
|
||
- name: Install dependencies | ||
shell: bash | ||
run: | | ||
sudo apt-get update -qq -y | ||
sudo apt-get install -qq -y python3-pip python3 | ||
sudo pip3 install git-archive-all | ||
|
||
- name: Calculate tag name | ||
shell: bash | ||
run: | | ||
name=dev | ||
if [[ $GITHUB_REF == refs/tags/v* ]]; then | ||
name=${GITHUB_REF:10} | ||
fi | ||
echo ::set-output name=val::$name | ||
echo TAG=$name >> $GITHUB_ENV | ||
id: tagname | ||
|
||
- name: Build archive | ||
shell: bash | ||
run: | | ||
git-archive-all --prefix=helix-$TAG helix-$TAG.tar.gz | ||
|
||
- uses: actions/[email protected] | ||
with: | ||
name: helix-source | ||
path: helix-*.tar.gz | ||
|
||
publish: | ||
name: Publish | ||
needs: [dist] | ||
needs: [dist, source] | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout sources | ||
|
@@ -121,7 +158,9 @@ jobs: | |
# with: | ||
# path: dist | ||
# - run: ls -al ./dist | ||
- run: ls -al bins-* | ||
- run: | | ||
ls -al bins-* | ||
ls -la helix-source | ||
|
||
- name: Calculate tag name | ||
run: | | ||
|
@@ -160,6 +199,7 @@ jobs: | |
(cd tmp && 7z a -r ../dist/$pkgname.zip $pkgname) | ||
fi | ||
done | ||
mv helix-source/helix-$TAG.tar.gz dist/ | ||
|
||
- name: Upload binaries to release | ||
uses: svenstaro/upload-release-action@v2 | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like the extra dependencies here. Since the submodules are already checked out it should be enough to package
helix-syntax/languages/*
. Let's hold off on this until we decide on #1560 thoughThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, for this case it should hopefully be simple enough to use tar with --exclude-vcs