optimize lsp_pos_to_pos #1423
Merged
optimize lsp_pos_to_pos #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirawi
force-pushed
the
opt
branch
2 times, most recently
from
31134bf to
4615fde
Compare
archseer
requested changes
Jan 3, 2022
| @@ -66,39 +66,26 @@ pub mod util { | |||
| pos: lsp::Position, | |||
| offset_encoding: OffsetEncoding, | |||
| ) -> Option<usize> { | |||
| let max_line = doc.lines().count().saturating_sub(1); | |||
There was a problem hiding this comment.
Oh wow, that was missed in the original PR review.
| let pos_line = pos.line as usize; | ||
| let pos_line = if pos_line > max_line { | ||
| if pos_line > doc.len_lines() - 1 { |
There was a problem hiding this comment.
Should still use saturating_sub if you have 0 lines (no line endings)
There was a problem hiding this comment.
I noticed that it would return 1 even on an empty string "" in the tests:
Line 456 in cc03a25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to work.