Add c-f c-d keymap to file_picker to filter option. #1405

cossonleo · 2021-12-30T05:49:07Z

add c-f to file_picker for filter path starts_with current file's dir
add c-d to file_picker for filter path starts_with cwd

dead10ck · 2021-12-30T21:23:19Z

helix-term/src/ui/picker.rs

+                EventResult::Consumed(None)
+            }
+            ctrl!('f') => {
+                if let Some(cwd) = doc!(ctx.editor).path().and_then(|p| p.parent()) {


cwd is misleading, as the current file will not always be in the current working directory. This should be something like doc_dir.

What does doc_dir mean?

Document directory...

dead10ck · 2021-12-31T02:36:13Z

book/src/keymap.md

@@ -306,6 +306,15 @@ Keys to use within picker. Remapping currently not supported.
 | `Ctrl-v`                     | Open vertically   |
 | `Escape`, `Ctrl-c`           | Close picker      |

+## File Picker extra keymap


Is there any reason these can't just go into the Picker section's table?

The shortcut only works on FilePicker.

Are you telling me that these shortcuts in the File Picker section work outside of the file picker?

helix/book/src/keymap.md

Lines 297 to 309 in ddbf036

# Picker

Keys to use within picker. Remapping currently not supported.

| Key | Description |

| ----- | ------------- |

| `Up`, `Ctrl-k`, `Ctrl-p` | Previous entry |

| `Down`, `Ctrl-j`, `Ctrl-n` | Next entry |

| `Ctrl-space` | Filter options |

| `Enter` | Open selected |

| `Ctrl-s` | Open horizontally |

| `Ctrl-v` | Open vertically |

| `Escape`, `Ctrl-c` | Close picker |

Yes, those shortcuts works on any picker and this is specific to file picker.

Ohhhh, I see, sorry for my confusion. In that case, could we update the title to just "File picker", and update the wording in the sentence just below here to say that these are specific to the file picker?

helix-term/src/ui/picker.rs

twe4ked · 2022-01-11T23:33:05Z

Love the idea of having this functionality. Just calling out that there is an open issue (#1467) to add C-d and C-u mappings to the picker UI, these don't conflict but I think it might be worth considering what other mappings might be added in future.

Another alternative could be to introduce more SPACE mappings for these specific cases? Or potentially exposing these as commands (not sure what to call this?) that people can add their own mappings for (with no default).

pickfire · 2022-01-12T15:39:17Z

helix-term/src/ui/picker.rs

+            ctrl!('a') => {
+                if let Ok(cwd) = std::env::current_dir() {
+                    filter(cwd.as_path());
+                }
+                EventResult::Consumed(None)
+            }
+            ctrl!('f') => {
+                if let Some(cwd) = doc!(cx.editor).path().and_then(|p| p.parent()) {
+                    filter(cwd);
+                }
+                EventResult::Consumed(None)
+            }


Hmm, this seemed oddly specific. Do you know any prior art that do something similar? I don't see something like this in doom emacs IIRC or maybe I didn't dig deep, also stuff like these are hard to discover. And what is your usecase?

I wonder if it would be good to C-r % to paste the current file and C-w to remove the last file path to do the same without doing something so specific?

hovsater · 2022-01-15T16:04:52Z

While I think these filters are a nice addition, I also think we should be careful with binding ctrl+ combinations. As @twe4ked pointed out, C-d and C-u are sometimes used for navigating a page down or up. As an example, we're already using it for the popup at hover.

hahanein · 2022-01-20T14:51:22Z

ctrl-f, too, is being used instead of page down: #41 cbb3eba

Maybe you could start a search string in a specialized way and helix would know to interpret it as doc_dir?

. mysearchstring

...would only look up entries in /path/to/doc_dir/.

Or more restrictive but more obvious, too:

./mysearchstring

...translates to effectively searching for:

/path/to/doc_dir/mysearchstring

bbodi · 2022-01-21T19:34:34Z

If this will be merged, #1352 can be closed as this one solves the same issue without taking away any space shortcut.

cossonleo · 2022-01-23T15:37:41Z

How about c-a and c-l?

pickfire · 2022-01-24T15:21:52Z

If this will be merged, #1352 can be closed as this one solves the same issue without taking away any space shortcut.

Nope, @bbodi I think it would be good to have space f F for that later, but maybe for now that can still be space F.

How about c-a and c-l?

Not sure if we want this but I think it would be good to rethink the approach. For me I think it's better to ctrl-r % to paste the current file name and ctrl-w to remove the filename, I think that is more consistent with normal mode and command mode so users don't have to learn new commands, instead of the approach taken here (at least I don't think it's common enough to warrant a shortcut), say if you want to go up two directories, just ctrl-w twice, or if you want to open the parent directory of alternate file, just ctrl-r # and ctrl-w. @cossonleo What do you think?

twe4ked · 2022-01-25T22:02:37Z

How about c-a and c-l?

FWIW C-a is often jump to start of line in emacs bindings (most shells and common in REPLs).

Could we somehow make this optional for a time with a way to add it as a keybind? Then see how the bindings progress across the editor?

add c-f to file_picker for filter path starts_with current file's dir

pickfire · 2022-02-16T14:56:00Z

If you ask me, I probably won't give approval for this pull request since it is very specific and not inter-changable with other parts, other users may not be able to figure this out easily. If anything I still think ctrl-r % + ctrl-w is a more flexible option to let users remove as many subpath if they want. Say if a user want a parent directory of parent directory, the current approach does not support that. Not sure about other maintainers, this is only my personal opinion.

pickfire · 2022-06-08T00:57:31Z

#2458 (support insert register in prompt) is now merged, so if we add support for ctrl-r % current file register and tweak the behavior of ctrl-w in prompt to delete until the parent directory in prompt, I guess this should be set to be able to use ctrl-r % + ctrl-w which is more interoperable with other parts.

pascalkuthe · 2024-04-13T22:28:53Z

I am closig this PR as it has gone stale. I also don't think we will be looking to add a feature like this to core. Its too specific/niche and IMO better covered by features like c-F.

Thank you for contributing!

dead10ck requested changes Dec 31, 2021

View reviewed changes

kirawi reviewed Jan 1, 2022

View reviewed changes

helix-term/src/ui/picker.rs Outdated Show resolved Hide resolved

cossonleo force-pushed the file_picker_improve branch from 69020ed to 6d36207 Compare January 11, 2022 05:48

cossonleo requested a review from kirawi January 11, 2022 05:48

pickfire reviewed Jan 12, 2022

View reviewed changes

cossonleo force-pushed the file_picker_improve branch from 6d36207 to 8e985be Compare January 24, 2022 07:52

cossonleo added 3 commits February 14, 2022 10:12

add c-d to file_picker for filter path starts_with cwd

75997b5

add c-f to file_picker for filter path starts_with current file's dir

rename ctx to cx

4b84f59

change to c-f c-a

64a79d5

cossonleo force-pushed the file_picker_improve branch from 0ef3605 to 64a79d5 Compare February 14, 2022 02:13

the-mikedavis added the S-needs-discussion Status: Needs discussion or design. label May 18, 2022

kirawi added the A-helix-term Area: Helix term improvements label Sep 13, 2022

pascalkuthe closed this Apr 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add c-f c-d keymap to file_picker to filter option. #1405

Add c-f c-d keymap to file_picker to filter option. #1405

cossonleo commented Dec 30, 2021

dead10ck Dec 30, 2021

cossonleo Jan 11, 2022

dead10ck Feb 17, 2022

dead10ck Dec 31, 2021

cossonleo Jan 11, 2022

dead10ck Jan 11, 2022

pickfire Jan 12, 2022

dead10ck Jan 13, 2022

twe4ked commented Jan 11, 2022

pickfire Jan 12, 2022

hovsater commented Jan 15, 2022 •

edited

Loading

hahanein commented Jan 20, 2022 •

edited

Loading

bbodi commented Jan 21, 2022

cossonleo commented Jan 23, 2022

pickfire commented Jan 24, 2022 •

edited

Loading

twe4ked commented Jan 25, 2022

pickfire commented Feb 16, 2022 •

edited

Loading

pickfire commented Jun 8, 2022 •

edited

Loading

pascalkuthe commented Apr 13, 2024

	# Picker

	Keys to use within picker. Remapping currently not supported.

	\| Key \| Description \|
	\| ----- \| ------------- \|
	\| `Up`, `Ctrl-k`, `Ctrl-p` \| Previous entry \|
	\| `Down`, `Ctrl-j`, `Ctrl-n` \| Next entry \|
	\| `Ctrl-space` \| Filter options \|
	\| `Enter` \| Open selected \|
	\| `Ctrl-s` \| Open horizontally \|
	\| `Ctrl-v` \| Open vertically \|
	\| `Escape`, `Ctrl-c` \| Close picker \|

Add c-f c-d keymap to file_picker to filter option. #1405

Add c-f c-d keymap to file_picker to filter option. #1405

Conversation

cossonleo commented Dec 30, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

twe4ked commented Jan 11, 2022

Choose a reason for hiding this comment

hovsater commented Jan 15, 2022 • edited Loading

hahanein commented Jan 20, 2022 • edited Loading

bbodi commented Jan 21, 2022

cossonleo commented Jan 23, 2022

pickfire commented Jan 24, 2022 • edited Loading

twe4ked commented Jan 25, 2022

pickfire commented Feb 16, 2022 • edited Loading

pickfire commented Jun 8, 2022 • edited Loading

pascalkuthe commented Apr 13, 2024

hovsater commented Jan 15, 2022 •

edited

Loading

hahanein commented Jan 20, 2022 •

edited

Loading

pickfire commented Jan 24, 2022 •

edited

Loading

pickfire commented Feb 16, 2022 •

edited

Loading

pickfire commented Jun 8, 2022 •

edited

Loading