Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dracula theme #1258

Merged
merged 6 commits into from
Dec 20, 2021
Merged

Add dracula theme #1258

merged 6 commits into from
Dec 20, 2021

Conversation

loewenheim
Copy link
Contributor

I based this as closely as I could on the specification.

runtime/themes/dracula.toml Outdated Show resolved Hide resolved
Comment on lines 18 to 29
"ui.background" = { fg = "foreground", bg = "background" }
"ui.cursor" = { fg = "black", bg = "orange", modifiers = ["dim"] }
"ui.cursor.primary" = { fg = "black", bg = "cyan", modifier = ["dim"] }
"ui.cursor.match" = { fg = "green", modifiers = ["underlined"] }
"ui.linenr" = { fg = "comment" }
"ui.linenr.selected" = { fg = "foreground" }
"ui.statusline" = { fg = "foreground", bg = "background_dark" }
"ui.selection" = { fg = "black", bg = "purple", modifiers = ["dim"] }
"ui.selection.primary" = { fg = "black", bg = "pink" }
"ui.text" = { fg = "foreground" }
"error" = { fg = "red" }
"warning" = { fg = "cyan" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this is missing a few styles, ui.popup, ui.window, ui.help, ui.menu, ui.menu.selected etc. ui.text.focus

Also info and hint. Are you sure you don't want to style these?

Copy link
Contributor Author

@loewenheim loewenheim Dec 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the reminder that I still needed to deal with these. Unfortunately I can't figure out what ui.menu does.

ETA: The same goes for ui.cursor.insert and ui.info.

Copy link
Contributor

@CptPotato CptPotato Dec 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the reminder that I still needed to deal with these. Unfortunately I can't figure out what ui.menu does.

ETA: The same goes for ui.cursor.insert and ui.info.

ui.cursor.insert is the color of the cursor in insert mode. It only works when ui.cursor.primary isn't set, though.
It's the same case for ui.cursor.select (-> visual mode).

info (not ui.info afaik) is used for infos such as suggestions and other lints from the LSP, like error and warning.

I wasn't able to find out what ui.menu refers to, though :/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ui.menu is used for the completion menu, and the picker "menu" (the left pane with the file list)

runtime/themes/dracula.toml Outdated Show resolved Hide resolved
@loewenheim loewenheim requested a review from archseer December 19, 2021 21:58
@archseer
Copy link
Member

Thanks! 🎉

@archseer archseer merged commit 7438db6 into helix-editor:master Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants