fix: unable to detect Color completion item hex code for some LSPs #12501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik-rev
changed the title
Co-authored-by: Michael Davis <[email protected]>
Co-authored-by: Michael Davis <[email protected]>
the-mikedavis
approved these changes
Jan 12, 2025
rmburg
pushed a commit
to rmburg/helix
that referenced
this pull request
Jan 20, 2025
…elix-editor#12501) Co-authored-by: Nikita Revenco <[email protected]>
VishnuTejaBandi
pushed a commit
to VishnuTejaBandi/helix
that referenced
this pull request
Jan 21, 2025
…elix-editor#12501) Co-authored-by: Nikita Revenco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #12299 (comment) it was discovered that some LSPs also send additional documentation per LSP color, other than the color's hex code
Since our current approach is to check if the entire documentation matches a hex code, this meant the hex code can't be detected
With this PR, we now check against the end of the documentation, which means all LSPs which currently work will continue to work, but LSPs that send extra documentation per-color (like Dart LSP) will work as well.