fix(highlights): recognize ! as the never type
#12485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archseer
requested changes
Jan 11, 2025
| @@ -453,8 +456,6 @@ | |||
| ; Remaining Identifiers | |||
| ; ------- | |||
|
|
|||
| "?" @special | |||
There was a problem hiding this comment.
This is deliberate and allows styling ? differently, as many highlighters do. @operator.special might have been a better scope, but @special is already documented so the change would break themes (including the intent of the default theme)
nik-rev
changed the title
? as an operator and recognize ! as the never type! as the never type
the-mikedavis
approved these changes
Jan 11, 2025
rmburg
pushed a commit
to rmburg/helix
that referenced
this pull request
Jan 20, 2025
Co-authored-by: Nikita Revenco <[email protected]>
VishnuTejaBandi
pushed a commit
to VishnuTejaBandi/helix
that referenced
this pull request
Jan 21, 2025
Co-authored-by: Nikita Revenco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.