Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: autohelp for delete, replace and add surrounds #12262

Merged
merged 4 commits into from
Dec 22, 2024
Merged

feat: autohelp for delete, replace and add surrounds #12262

merged 4 commits into from
Dec 22, 2024

Conversation

nik-rev
Copy link
Contributor

@nik-rev nik-rev commented Dec 15, 2024 •
edited
Loading

image

image

image

image

@the-mikedavis the-mikedavis added A-documentation Area: Documentation improvements A-command Area: Commands labels Dec 16, 2024
@the-mikedavis
tweak wording "nearest"=>"surrounding"
29fe785 
"nearest" could possibly be interpreted as saying that `md"` for example
will delete the next pair of `"`s on the line even if the quotes don't
surround the cursor
@the-mikedavis
Copy link
Member

I tweaked the wording a bit but otherwise this looks good. There are some other unicode pair characters (see PAIRS in match_brackets.rs) but I think we can ignore them for the infobox popup: the common ASCII characters should be enough

@the-mikedavis the-mikedavis merged commit ac4c017 into helix-editor:master Dec 22, 2024
6 checks passed
CedricMeu pushed a commit to CedricMeu/helix that referenced this pull request Jan 2, 2025
@nik-rev
feat: autohelp for delete, replace and add surrounds (helix-editor#12262
c272b56 
)
GladkihEgor pushed a commit to GladkihEgor/helix that referenced this pull request Jan 4, 2025
@nik-rev @GladkihEgor
feat: autohelp for delete, replace and add surrounds (helix-editor#12262
4e40046 
)
diucicd pushed a commit to diucicd/helix that referenced this pull request Jan 8, 2025
@nik-rev @rongyi
feat: autohelp for delete, replace and add surrounds (helix-editor#12262
21113c9 
)
rmburg pushed a commit to rmburg/helix that referenced this pull request Jan 20, 2025
@nik-rev @rmburg
feat: autohelp for delete, replace and add surrounds (helix-editor#12262
567af79 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
A-command Area: Commands A-documentation Area: Documentation improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nik-rev @the-mikedavis