fix: Respect workspace-lsp-roots on doc opening #12223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a new language server is started, find_lsp_workspace is called with LanguageConfiguration::workspace_lsp_roots as the root_dirs. This behavior is different when a new document is opened. find_lsp_workspace is called with editor::Config::workspace_lsp_roots which is never set. This leads to a bug where workspace-lsp-roots is not respected when opening a new document. This commit fixes this bug.
TornaxO7
approved these changes
Dec 16, 2024
Like |
CedricMeu
pushed a commit
to CedricMeu/helix
that referenced
this pull request
Jan 2, 2025
When a new language server is started, find_lsp_workspace is called with LanguageConfiguration::workspace_lsp_roots as the root_dirs. This behavior is different when a new document is opened. find_lsp_workspace is called with editor::Config::workspace_lsp_roots which is never set. This leads to a bug where workspace-lsp-roots is not respected when opening a new document. This commit fixes this bug.
GladkihEgor
pushed a commit
to GladkihEgor/helix
that referenced
this pull request
Jan 4, 2025
When a new language server is started, find_lsp_workspace is called with LanguageConfiguration::workspace_lsp_roots as the root_dirs. This behavior is different when a new document is opened. find_lsp_workspace is called with editor::Config::workspace_lsp_roots which is never set. This leads to a bug where workspace-lsp-roots is not respected when opening a new document. This commit fixes this bug.
diucicd
pushed a commit
to diucicd/helix
that referenced
this pull request
Jan 8, 2025
When a new language server is started, find_lsp_workspace is called with LanguageConfiguration::workspace_lsp_roots as the root_dirs. This behavior is different when a new document is opened. find_lsp_workspace is called with editor::Config::workspace_lsp_roots which is never set. This leads to a bug where workspace-lsp-roots is not respected when opening a new document. This commit fixes this bug.
rmburg
pushed a commit
to rmburg/helix
that referenced
this pull request
Jan 20, 2025
When a new language server is started, find_lsp_workspace is called with LanguageConfiguration::workspace_lsp_roots as the root_dirs. This behavior is different when a new document is opened. find_lsp_workspace is called with editor::Config::workspace_lsp_roots which is never set. This leads to a bug where workspace-lsp-roots is not respected when opening a new document. This commit fixes this bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new language server is started,
find_lsp_workspaceis called withLanguageConfiguration::workspace_lsp_rootsas theroot_dirsargument.This behavior is different when a new document is opened.
find_lsp_workspaceis called witheditor::Config::workspace_lsp_rootswhich is never set.This leads to a bug where
workspace-lsp-rootsis not respected when opening a new document. This commit fixes this bug.I don't quite understand why the field
editor::Config::workspace_lsp_rootsexists when it is never used. Is it something LSP specific?I'm also happy to change this PR if someone can point me into the right direction if the current fix is wrong.
Thanks a lot!
Closes #12222