Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option for continue commenting #12213

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

TornaxO7
Copy link
Contributor

@TornaxO7 TornaxO7 commented Dec 7, 2024

This fixes #1730 (comment)

@johnbchron may I ask if you could try my PR out? My PR adds the field in the [editor] section. Just add a continue-comment = false line and you should be good to go.

I'm also wondering if it might be worth it to add a command for this: :set-continue-comment [true/false]

pascalkuthe
pascalkuthe previously approved these changes Dec 8, 2024
Copy link
Member

@pascalkuthe pascalkuthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't love adding new config options but this feature has a pretty big effect and I can see not everyone liking it I suppose (altough definitly keep it enabled by default, even vim has this by default)

@johnbchron
Copy link

@TornaxO7 works for me.

@pascalkuthe I agree that it's a reasonable default but in some projects it adds a bunch of unnecessary work to have permanently enabled. I appreciate you allowing the config option.

book/src/editor.md Outdated Show resolved Hide resolved
Co-authored-by: Michael Davis <[email protected]>
@TornaxO7 TornaxO7 force-pushed the config-continue-comment branch from 5180f9d to e1f8313 Compare December 9, 2024 23:03
@the-mikedavis the-mikedavis merged commit 5005c14 into helix-editor:master Dec 9, 2024
6 checks passed
@@ -31,6 +31,7 @@
| `line-number` | Line number display: `absolute` simply shows each line's number, while `relative` shows the distance from the current line. When unfocused or in insert mode, `relative` will still show absolute line numbers | `absolute` |
| `cursorline` | Highlight all lines with a cursor | `false` |
| `cursorcolumn` | Highlight all columns with a cursor | `false` |
| `continue-comments` | if helix should automatically add a line comment token if you create a new line inside a comment. | `false` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, typo here I think re. the default: s/false/true/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah oof, true ._.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Continue comments
5 participants