Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed explict default config file from swift-format #12052

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

lizclipse
Copy link
Contributor

This is the default file name, and explicitly providing it as an argument causes an error if the file does not exist.

Also, just a QQ: how come some langs have auto-format enabled and some dont? Surely all off by default (to be the least annoying) would make more sense? At the least, having all the langs 1 way or the other would be more consistent to me.

@archseer archseer merged commit 10c3502 into helix-editor:master Nov 11, 2024
6 checks passed
@lizclipse lizclipse deleted the fix-swift-format branch November 11, 2024 13:31
@the-mikedavis
Copy link
Member

how come some langs have auto-format enabled and some dont?

The ecosystems for some languages like Rust basically always format so setting it to true is a better default. By default though auto-format is false and we generally don't set it to true unless it's the expected behavior for that languages' ecosystem. (For example we don't set it to true for JavaScript since JavaScript projects are not formatted ubiquitously and there isn't a "one true formatter" in the ecosystem.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants