Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme: Seoul256 dark & light #11466

Merged
merged 8 commits into from
Nov 20, 2024

Conversation

EricHenry
Copy link
Contributor

Dark color scheme based on Seoul256

Screenshot 2024-08-11 at 5 06 22 PM

the-mikedavis
the-mikedavis previously approved these changes Aug 12, 2024
@the-mikedavis the-mikedavis added A-language-support Area: Support for programming/text languages A-theme Area: Theme and appearence related and removed A-language-support Area: Support for programming/text languages labels Aug 12, 2024
@archseer
Copy link
Member

Could you also use inherits to add a light variant? The scheme was designed to work with both light and dark variants so it shouldn't require other changes

@EricHenry
Copy link
Contributor Author

@archseer yeah totally, you got it. I'll add the light variant in.

@EricHenry EricHenry changed the title Theme: Seoul256 dark Theme: Seoul256 dark & light Aug 17, 2024
@EricHenry
Copy link
Contributor Author

@the-mikedavis @archseer Should be ready for re-review. Now includes light and dark themes, with soft and hard variants.

Screenshot 2024-08-17 at 1 50 29 AM Screenshot 2024-08-17 at 1 50 42 AM Screenshot 2024-08-17 at 1 50 55 AM Screenshot 2024-08-17 at 1 51 06 AM Screenshot 2024-08-17 at 1 51 17 AM Screenshot 2024-08-17 at 1 51 30 AM

@the-mikedavis the-mikedavis merged commit aa10b1f into helix-editor:master Nov 20, 2024
6 checks passed
GladkihEgor pushed a commit to GladkihEgor/helix that referenced this pull request Jan 4, 2025
diucicd pushed a commit to diucicd/helix that referenced this pull request Jan 8, 2025
rmburg pushed a commit to rmburg/helix that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants