Gruvbox light theme. Fix cursorline readability after #10773. #11071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
mxxntype
pushed a commit
to mxxntype/helix
that referenced
this pull request
Aug 14, 2024
kyruzic
pushed a commit
to kyruzic/helix
that referenced
this pull request
Sep 27, 2024
salman-farooq-sh
pushed a commit
to salman-farooq-sh/helix
that referenced
this pull request
Dec 21, 2024
* Add new color theme 'iroaseta' * Update runtime/themes/iroaseta.toml Co-authored-by: postsolar <[email protected]> * Update iroaseta.toml Add virtual jump label theme setting * Update runtime/themes/iroaseta.toml Co-authored-by: Michael Davis <[email protected]> * Update iroaseta.toml update storage. keyword.storage. according to suggestion, and update color. * Update iroaseta.toml remove unused palette * Update iroaseta.toml add missing setting for bufferline * Update iroaseta.toml update diagnostic fg color * Update iroaseta.toml I made the config more comprehensive and took all available themes settings from the manual. Some are commented out though. * Update iroaseta.toml add missing colors * Update iroaseta.toml Made some final adjustments to the color theme to improve visibility and reduce eye strain. * Update runtime/themes/iroaseta.toml Co-authored-by: Michael Davis <[email protected]> * Update runtime/themes/iroaseta.toml Co-authored-by: Michael Davis <[email protected]> * Update iroaseta.toml remove redundant settings * Update iroaseta.toml update color name --------- Co-authored-by: postsolar <[email protected]> Co-authored-by: Michael Davis <[email protected]> Large Gruvbox refactoring (helix-editor#10773) * gruvbox refactoring * removed unnecessary lines * set purple1 for operators * changed diagnostics colors * removed some unnecessary lines * set diff.delta color to yellow * removed some tag colors Delay auto-save until exiting insert mode (helix-editor#11047) Saving while in insert mode causes issues with the modification indicator and this is very easy to reproduce with the current state of the auto-save hook. We can tweak the hook slightly to await the mode switch out of insert mode to perform the save. The debounce is preserved: if you save and then immediately exit insert mode the debounce will be respected. If the debounce lapses while you are in insert mode, the save occurs as you switch out of insert mode immediately. VHDL highlights.scm improvement (helix-editor#10845) Fix homebrew formula link (helix-editor#11058) Co-authored-by: Mark Murphy <[email protected]> build(deps): bump the rust-dependencies group with 3 updates (helix-editor#11072) Bumps the rust-dependencies group with 3 updates: [log](https://github.com/rust-lang/log), [serde_json](https://github.com/serde-rs/json) and [cc](https://github.com/rust-lang/cc-rs). Updates `log` from 0.4.21 to 0.4.22 - [Release notes](https://github.com/rust-lang/log/releases) - [Changelog](https://github.com/rust-lang/log/blob/master/CHANGELOG.md) - [Commits](rust-lang/log@0.4.21...0.4.22) Updates `serde_json` from 1.0.117 to 1.0.120 - [Release notes](https://github.com/serde-rs/json/releases) - [Commits](serde-rs/json@v1.0.117...v1.0.120) Updates `cc` from 1.0.100 to 1.0.104 - [Release notes](https://github.com/rust-lang/cc-rs/releases) - [Changelog](https://github.com/rust-lang/cc-rs/blob/main/CHANGELOG.md) - [Commits](rust-lang/cc-rs@cc-v1.0.100...cc-v1.0.104) --- updated-dependencies: - dependency-name: log dependency-type: direct:production update-type: version-update:semver-patch dependency-group: rust-dependencies - dependency-name: serde_json dependency-type: direct:production update-type: version-update:semver-patch dependency-group: rust-dependencies - dependency-name: cc dependency-type: direct:production update-type: version-update:semver-patch dependency-group: rust-dependencies ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> chore: update cairo tree sitter + queries (helix-editor#11067) Bump time from broken version (0.3.23) (helix-editor#11065) Tell language servers that Helix can request formatting (helix-editor#11064) Without providing the formatting capability, the language server might not advertise its ability to format in return, causing the :format command to be broken. Override far too dark cursorline (helix-editor#11071) Add hsc filetype to haskell (helix-editor#11074)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Religious Gruvbox light user here. @Chirikumbrah recently made a number of excellent tweaks to the base Gruvbox theme (#10773). One of these has had the unfortunate effect of turning the non-primary cursor line dark, making the text of the current line unreadable due to poor contrast. This is shown in the 'before' panel of the image below.
This PR sets things right by overriding the non-primary cursor background in the Gruvbox Light variant (which propagates to the other Light variants through inheritance.) The result is shown in the 'after' panel.
Question for @Chirikumbrah: I see you've defined a special
bg0_s = "#32302f"(dark0_soft in gruvbox.nvim) for the cursorline. This is the same color as the background in Gruvbox Dark Soft, meaning that the non-primary cursorline doesn't appear when using that variant. Do you think we should a) drop bg0_s altogether or b) specify a separate"ui.cursorline"in the Dark Soft variant, so that it appears again? I ask because, if we keep bg0_s, it would probably be more consistent if I defined a separate bg0_s in the Light theme (light0_soft in gruvbox.nvim, to be specific).