Continue line comments #10996
Merged
Continue line comments #10996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n1991/helix into feature/continue-comment
…lix into continue-single-comment
TornaxO7
force-pushed
the
continue-single-comment
branch
from
57b449c to
0fccc92
Compare
TornaxO7
force-pushed
the
continue-single-comment
branch
from
0fccc92 to
8fa3cc9
Compare
|
One thing which bothers me is how we want to "continue" the comment from block comments like for C of this style: Should this be tackled in this PR or in another PR? Should this be tackled at all? |
TornaxO7
force-pushed
the
continue-single-comment
branch
from
5a2a96e to
b7f9780
Compare
the-mikedavis
previously approved these changes
Oct 7, 2024
pascalkuthe
reviewed
Oct 18, 2024
| new_text.push_str(token); | ||
| new_text.push(' '); | ||
| new_text.chars().count() | ||
| } else if on_auto_pair { |
There was a problem hiding this comment.
I don't think this is a limitation we want to have in thr lognterm but usually autopairs within comments are a bit niche and likely hard to fix until some other changss land so this is probably fine for now.
pascalkuthe
previously approved these changes
Oct 19, 2024
TornaxO7
force-pushed
the
continue-single-comment
branch
from
18d007a to
12a8b3e
Compare
pascalkuthe
approved these changes
Oct 19, 2024
the-mikedavis
approved these changes
Oct 19, 2024
|
|
|
This just made my night. Thank you @TornaxO7 & rest of the maintainers 🙌🏾 🙌🏾 for the steady progress. |
|
You're welcome |
salman-farooq-sh
pushed a commit
to salman-farooq-sh/helix
that referenced
this pull request
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1730
Continues #8664
This is my attempt to apply the changes of #4718 to the PR.