Optimize space for DocumentId with NonZeroUsize #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omnikar
reviewed
Nov 14, 2021
helix-view/src/editor.rs
Outdated
Comment on lines
323
to
325
| // Safety: adding 1 from 1 is fine, probably impossible to reach usize max | ||
| self.next_document_id = | ||
| unsafe { NonZeroUsize::new_unchecked(self.next_document_id.get() + 1) }; |
There was a problem hiding this comment.
While it "probably" won't happen, it technically could, so I'm not sure we should leave it such that it technically could cause UB.
There was a problem hiding this comment.
Technically is possible but if the user have that many documents opened, he probably hit an OOM first rather than this. And chances are the files won't hit that, my filesystem only has like 8881511 and 18446744073709551615 is the max, still a long way to go.
And btrfs and ext4 you can't hit that, maybe zfs can since it supports 2^128.
There was a problem hiding this comment.
We can simplify once nonzero_ops gets stabilized, by using saturating_add.
archseer
requested changes
Nov 20, 2021
pickfire
force-pushed
the
documentid-size
branch
from
074fb0a to
14607da
Compare
Now Option<DocumentId> uses one byte rather than two
pickfire
force-pushed
the
documentid-size
branch
from
14607da to
040a64f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
Option<DocumentId>uses one byte rather than two