Custom file picker width max min and factor #1089

Rational-Curiosity · 2021-11-12T23:36:23Z

This allow custom file picker width settings

Omnikar · 2021-11-13T19:45:57Z

This isn't a percentage.

Rational-Curiosity · 2021-11-13T23:36:29Z

This isn't a percentage.

I have removed the word 'percentage' and expanded the meaning of the variable.

sudormrfbin · 2021-11-14T05:02:26Z

book/src/configuration.md

@@ -23,6 +23,7 @@ To override global configuration parameters, create a `config.toml` file located
 | `idle-timeout` | Time in milliseconds since last keypress before idle timers trigger. Used for autocompletion, set to 0 for instant. | `400` |
 | `completion-trigger-len` | The min-length of word under cursor to trigger autocompletion | `2` |
 | `auto-info` | Whether to display infoboxes | `true` |
+| `file-picker-width` | File picker width, values from 0.0 to 1.0 treated as a factor | `0.5` |


There's going to be an editor.file-picker section (#988) so this can be a key in that sub config.

Ok, then we have to wait #988 to be merged

sudormrfbin · 2021-11-14T05:04:55Z

helix-term/src/ui/picker.rs

@@ -166,7 +166,12 @@ impl<T: 'static> Component for FilePicker<T> {
        surface.clear_with(area, background);

        let picker_width = if render_preview {


It would be less confusing to have the config as preview-width instead of picker-width since I would assume picker-width to mean the width of the entire window (including the preview and the picker).

But preview is the right side not always showed. Maybe we have to choose a name for the left side of the picker. Suggestions?

Then I think we can have two different options - file-picker.width and file-picker.preview-width. width can control the whole picker + preview window size and preview-width can control the size of the preview inside this window.

pickfire · 2021-11-14T07:21:18Z

I wonder if this could be represented using both percentage and/or min width? How do we factor those in later?

Rational-Curiosity · 2021-11-14T10:58:41Z

I wonder if this could be represented using both percentage and/or min width? How do we factor those in later?

Percentage and factor represents the same thing 50% = 0.5, and the current implementation allows both proportional part of the picker width or number of characters with only one variable (similar to how emacs do it). Min width is very interesting, any suggestion about how to name it?

helix-view/src/editor.rs

helix-term/src/ui/picker.rs

pickfire

Didn't get to test this out but code wise looks good to me. Just some comments left.

pickfire · 2021-11-24T14:38:21Z

book/src/configuration.md

+|`height-factor` | File picker height, treated as a factor. | `0.9` |
+|`preview-width-factor` | File picker preview width, treated as a factor. | `0.5` |
+|`preview-min-width` |  File picker preview minimum width in columns. | `60` |
+|`file-min-width` | File picker filenames minimum width in columns when preview is showed. | `20` |


filenames minimum width seemed confusing to me?

i know my English sucks ;-), any suggestion?

File picker preview minimum width in columns?

Not sure how to explain this too, hopefully someone can help.

pickfire · 2021-11-24T14:39:29Z

helix-view/src/editor.rs

+            preview_min_width: 60,
+            file_min_width: 20,


We should add a comment that both of this should total up to 80.

Ok. Out of curiosity, what is the reason? preview-min-width = 25, file-min-width = 20 works, and preview-min-width = 80, file-min-width = 30 works too.

I thought that's why you put 80? Like previously I saw a number 80 being removed, and you replaced it with the sum of these two.

At the very least I think we should still make it look nice for 80x24 terminals.

pickfire

Tried locally and didn't seemed to break current behavior so should be good.

archseer · 2021-12-19T15:00:30Z

helix-term/src/ui/picker.rs

+            cx.editor.config.file_picker.width_factor,
+            cx.editor.config.file_picker.height_factor,


Pass in &cx.editor.config.file_picker instead

archseer · 2021-12-19T15:01:05Z

helix-term/src/ui/picker.rs

+            > cx.editor.config.file_picker.preview_min_width
+                + cx.editor.config.file_picker.file_min_width;


This is a bit repetitive, add let config = &cx.editor.config.file_picker at the top of render

archseer · 2021-12-19T15:02:00Z

helix-term/src/ui/picker.rs

+            cmp::max(
+                area.width
+                    - cmp::max(
+                        preview_width,
+                        cx.editor.config.file_picker.preview_min_width,
+                    ),
+                cx.editor.config.file_picker.file_min_width,
+            )


Rather than cmp::max(a, b) a.max(b) can be used. In this case a.max(b).max(c).

archseer · 2021-12-19T15:02:50Z

helix-term/src/ui/picker.rs

+        vertical: (area.height as f32 * (1.0 - width_factor)).round() as u16,
+        horizontal: (area.width as f32 * (1.0 - height_factor)).round() as u16,


Using floats feels wrong to me, why not specify a percentage from 0-100?

kirawi · 2022-09-13T22:04:23Z

Closing as inactive. Feel free to open a new PR if you wish to continue.

Rational-Curiosity force-pushed the file-picker-perc-width branch from 074310c to 6cef00b Compare November 13, 2021 23:26

Rational-Curiosity changed the title ~~Custom file picker percentage width~~ Custom file picker width absolute and factor Nov 13, 2021

sudormrfbin reviewed Nov 14, 2021

View reviewed changes

Rational-Curiosity force-pushed the file-picker-perc-width branch from 6cef00b to 19f1940 Compare November 15, 2021 04:45

Rational-Curiosity force-pushed the file-picker-perc-width branch 2 times, most recently from bf4290a to 61be1fd Compare November 22, 2021 21:15

pickfire reviewed Nov 23, 2021

View reviewed changes

helix-view/src/editor.rs Outdated Show resolved Hide resolved

Rational-Curiosity changed the title ~~Custom file picker width absolute and factor~~ Custom file picker width max min and factor Nov 23, 2021

Rational-Curiosity force-pushed the file-picker-perc-width branch from 61be1fd to 635bad0 Compare November 23, 2021 20:41

pickfire reviewed Nov 24, 2021

View reviewed changes

helix-term/src/ui/picker.rs Show resolved Hide resolved

pickfire reviewed Nov 24, 2021

View reviewed changes

pickfire approved these changes Nov 25, 2021

View reviewed changes

Custom file picker width

679e772

Rational-Curiosity force-pushed the file-picker-perc-width branch from 635bad0 to 679e772 Compare November 25, 2021 20:16

archseer requested changes Dec 19, 2021

View reviewed changes

the-mikedavis added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 18, 2022

kirawi closed this Sep 13, 2022

kirawi added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Custom file picker width max min and factor #1089

Custom file picker width max min and factor #1089

Rational-Curiosity commented Nov 12, 2021 •

edited

Loading

Omnikar commented Nov 13, 2021

Rational-Curiosity commented Nov 13, 2021

sudormrfbin Nov 14, 2021

Rational-Curiosity Nov 14, 2021

sudormrfbin Nov 14, 2021

Rational-Curiosity Nov 14, 2021

sudormrfbin Nov 14, 2021

Rational-Curiosity Nov 23, 2021

pickfire commented Nov 14, 2021 •

edited

Loading

Rational-Curiosity commented Nov 14, 2021 •

edited

Loading

pickfire left a comment

pickfire Nov 24, 2021

Rational-Curiosity Nov 24, 2021

pickfire Nov 25, 2021

Rational-Curiosity Nov 25, 2021 •

edited

Loading

pickfire Nov 25, 2021

pickfire Nov 24, 2021 •

edited

Loading

Rational-Curiosity Nov 24, 2021

pickfire Nov 25, 2021

Rational-Curiosity Nov 25, 2021

pickfire left a comment

archseer Dec 19, 2021

archseer Dec 19, 2021

archseer Dec 19, 2021

archseer Dec 19, 2021

kirawi commented Sep 13, 2022

		@@ -166,7 +166,12 @@ impl<T: 'static> Component for FilePicker<T> {
		surface.clear_with(area, background);

		let picker_width = if render_preview {

		cx.editor.config.file_picker.width_factor,
		cx.editor.config.file_picker.height_factor,

		> cx.editor.config.file_picker.preview_min_width
		+ cx.editor.config.file_picker.file_min_width;

		vertical: (area.height as f32 * (1.0 - width_factor)).round() as u16,
		horizontal: (area.width as f32 * (1.0 - height_factor)).round() as u16,

Custom file picker width max min and factor #1089

Custom file picker width max min and factor #1089

Conversation

Rational-Curiosity commented Nov 12, 2021 • edited Loading

Omnikar commented Nov 13, 2021

Rational-Curiosity commented Nov 13, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pickfire commented Nov 14, 2021 • edited Loading

Rational-Curiosity commented Nov 14, 2021 • edited Loading

pickfire left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rational-Curiosity Nov 25, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pickfire Nov 24, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pickfire left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kirawi commented Sep 13, 2022

Rational-Curiosity commented Nov 12, 2021 •

edited

Loading

pickfire commented Nov 14, 2021 •

edited

Loading

Rational-Curiosity commented Nov 14, 2021 •

edited

Loading

Rational-Curiosity Nov 25, 2021 •

edited

Loading

pickfire Nov 24, 2021 •

edited

Loading