Handle is_incomplete #10822
Closed
Handle is_incomplete #10822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As I mentioned in #9797, I also wonder about changing the default completion trigger len to 1 instead of 2; this seems to be the default in most other software |
|
I appreciate the contribution. I was intending to implement thus differently (the ui should not be reriggered) and already have a local implementation of this. Implementing this the way I had in mind is complex and requires other changes to the ui (and I also improve other completion related things in that PR) that I haven't got around to finishing yet. I would rather just finish my branch since it's very far along already. Thanks for working on this regardless! |
|
Sounds good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #9797
This is not final but works decently; there are a few questions for maintainers in the comments
other than those, this appears to be quite slow and I do not know why