-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement read command #10447
Implement read command #10447
Conversation
It's customary to give the original author Co-authored-by attribution when reusing work: https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors |
I can do that. No problem. |
979b9c1
to
c265117
Compare
For the coauthor part, git/github is expecting the attribution in a
To fix the docs CI you can run |
Thank you for taking a look @the-mikedavis. All of the items identified have been resolved. |
the test associated with this command is failing on windows in ci |
Resurrects helix-editor#3966. This is 100% @idursun's work. Using read_to_string from helix-editor#7431. Co-authored-by: [email protected]
Co-authored-by: Michael Davis <[email protected]>
Co-authored-by: Ibrahim Dursun <[email protected]>
0a7e86a
to
a8c2d48
Compare
Co-authored-by: Michael Davis <[email protected]>
Co-authored-by: Michael Davis <[email protected]> Co-authored-by: Ibrahim Dursun <[email protected]>
Co-authored-by: Michael Davis <[email protected]> Co-authored-by: Ibrahim Dursun <[email protected]>
Co-authored-by: Michael Davis <[email protected]> Co-authored-by: Ibrahim Dursun <[email protected]>
Co-authored-by: Michael Davis <[email protected]> Co-authored-by: Ibrahim Dursun <[email protected]>
Resurrects #3966. This is 100% @idursun's work. Using
read_to_string
from #7431.closes #3796