-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dim primary selection in kanagawa #10094
Conversation
\cc @zetashift what do you think? IMO it would be better to make the selection background brighter rather than make the cursor and selection dimmer. The dim modifier turns down the contrast enough that it can be hard to read the selection contents |
Signed-off-by: Maksym Pavlenko <[email protected]>
Both of them look good to me as well, but if I have to chose I'll go with the |
Signed-off-by: Maksym Pavlenko <[email protected]>
Thanks! |
* [kanagawa] Change selection color Signed-off-by: Maksym Pavlenko <[email protected]> * [kanagawa] Use less brigh selection color Signed-off-by: Maksym Pavlenko <[email protected]> --------- Signed-off-by: Maksym Pavlenko <[email protected]>
* [kanagawa] Change selection color Signed-off-by: Maksym Pavlenko <[email protected]> * [kanagawa] Use less brigh selection color Signed-off-by: Maksym Pavlenko <[email protected]> --------- Signed-off-by: Maksym Pavlenko <[email protected]>
* [kanagawa] Change selection color Signed-off-by: Maksym Pavlenko <[email protected]> * [kanagawa] Use less brigh selection color Signed-off-by: Maksym Pavlenko <[email protected]> --------- Signed-off-by: Maksym Pavlenko <[email protected]>
* [kanagawa] Change selection color Signed-off-by: Maksym Pavlenko <[email protected]> * [kanagawa] Use less brigh selection color Signed-off-by: Maksym Pavlenko <[email protected]> --------- Signed-off-by: Maksym Pavlenko <[email protected]>
* [kanagawa] Change selection color Signed-off-by: Maksym Pavlenko <[email protected]> * [kanagawa] Use less brigh selection color Signed-off-by: Maksym Pavlenko <[email protected]> --------- Signed-off-by: Maksym Pavlenko <[email protected]>
* [kanagawa] Change selection color Signed-off-by: Maksym Pavlenko <[email protected]> * [kanagawa] Use less brigh selection color Signed-off-by: Maksym Pavlenko <[email protected]> --------- Signed-off-by: Maksym Pavlenko <[email protected]>
* [kanagawa] Change selection color Signed-off-by: Maksym Pavlenko <[email protected]> * [kanagawa] Use less brigh selection color Signed-off-by: Maksym Pavlenko <[email protected]> --------- Signed-off-by: Maksym Pavlenko <[email protected]>
* [kanagawa] Change selection color Signed-off-by: Maksym Pavlenko <[email protected]> * [kanagawa] Use less brigh selection color Signed-off-by: Maksym Pavlenko <[email protected]> --------- Signed-off-by: Maksym Pavlenko <[email protected]>
* [kanagawa] Change selection color Signed-off-by: Maksym Pavlenko <[email protected]> * [kanagawa] Use less brigh selection color Signed-off-by: Maksym Pavlenko <[email protected]> --------- Signed-off-by: Maksym Pavlenko <[email protected]>
I'm using
kanagawa
style and sometimes its pretty difficult to recognize selections:Here is an example.
No selection:
Selected:
This PR adds dimming to make it a bit more obvious: