Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight CODEOWNERS files #8091

Closed
yoav-lavi opened this issue Aug 28, 2023 · 1 comment · Fixed by #8220
Closed

Highlight CODEOWNERS files #8091

yoav-lavi opened this issue Aug 28, 2023 · 1 comment · Fixed by #8220
Labels
A-language-support Area: Support for programming/text languages C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much E-has-instructions Call for participation: Has instructions for fixing the issue and opening a PR

Comments

@yoav-lavi
Copy link
Contributor

Currently CODEOWNERS files (e.g. .github/CODEOWNERS) are not highlighted and treated as plain text
@yoav-lavi yoav-lavi added the C-enhancement Category: Improvements label Aug 28, 2023
@pascalkuthe
Copy link
Member

pascalkuthe commented Sep 8, 2023 •
edited
Loading

Any language sepport in helix needs its own tree sitter grammar. CODEOWNERS seems a bit niche to get its own TS grammar but it uses basically the same syntax as .gitignore files so adding that as an additional filename there seems reasonable to me

@pascalkuthe pascalkuthe added A-language-support Area: Support for programming/text languages E-easy Call for participation: Experience needed to fix: Easy / not much E-has-instructions Call for participation: Has instructions for fixing the issue and opening a PR labels Sep 8, 2023
@pascalkuthe pascalkuthe mentioned this issue Sep 9, 2023
Merged
rossmanch added a commit to rossmanch/helix that referenced this issue Sep 9, 2023
@rossmanch
chore: add highlighting for codeowners files
e43dfda 
Add `CODEOWNERS` as an additional file type for `git-ignore` in the
language file. `CODEOWNERS`'s grammar is close enough to that of
`.gitignore`, this can be used to avoid making a new grammar
specifically for `CODEOWNERS` files.

Resolves: helix-editor#8091
@pascalkuthe pascalkuthe linked a pull request Sep 9, 2023 that will close this issue
chore: add additional ignore file highlights #8220
Merged
rossmanch added a commit to rossmanch/helix that referenced this issue Sep 10, 2023
@rossmanch
chore: add highlighting for codeowners files
bc0bc79 
Add `CODEOWNERS` as an additional file type for `git-ignore` in the
language file. `CODEOWNERS`'s grammar is close enough to that of
`.gitignore`, this can be used to avoid making a new grammar
specifically for `CODEOWNERS` files.

Resolves: helix-editor#8091
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-language-support Area: Support for programming/text languages C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much E-has-instructions Call for participation: Has instructions for fixing the issue and opening a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add additional ignore file highlights rossmanch/helix
2 participants
@yoav-lavi @pascalkuthe