Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doom_acario_dark theme for Python #3533

Closed
AceofSpades5757 opened this issue Aug 24, 2022 · 6 comments
Closed

Update doom_acario_dark theme for Python #3533

AceofSpades5757 opened this issue Aug 24, 2022 · 6 comments
Labels
A-theme Area: Theme and appearence related C-enhancement Category: Improvements E-good-first-issue Call for participation: Issues suitable for new contributors

Comments

@AceofSpades5757
Copy link
Contributor

Not too familiar with themes and how they tie into tree-sitter/etc., but I noticed a couple that will make import blocks in Python look pretty wild.

This is doom_acario_dark, which looks really clean, until you scroll to the top.

image

@the-mikedavis the-mikedavis added C-enhancement Category: Improvements A-theme Area: Theme and appearence related E-good-first-issue Call for participation: Issues suitable for new contributors labels Aug 24, 2022
@the-mikedavis
Copy link
Member

doom_acario_dark highlights the namespace and keyword both as "red." from and import are captured as keywords and datetime on the first line for example is tagged as namespace in both usages.

(dotted_name
(identifier)* @namespace)

; from datetime import datetime
(import_from_statement
  module_name: (dotted_name (identifier))
  module_name: (dotted_name (identifier))

IMO the keyword and namespace captures for python are good choices. doom_acario_dark would probably benefit from changing the namespace style.

@archseer
Copy link
Member

\cc @Rinnray

@Aethrexal
Copy link
Contributor

I'll get to it right away.

@Aethrexal
Copy link
Contributor

I'm not really sure what's going on 😓 When I open up a python file it looks like this
image

Changing namespace doesn't change anything visible at least from that little snippet. From what I can see here at least, datetime is captured as a variable, so when I change variable to e.g green
image

Don't know if it's something I'm missing or what (probably is).
I could definitely still change the namespace to be another color; it's just that I can't check if it'll fix it or not myself.

@Aethrexal
Copy link
Contributor

Aethrexal commented Aug 25, 2022

Nevermind! I built Helix from source (had it from the AUR, I use Arch btw 😉) and it is namespace. Will be setting it to correct color and make a pr with the fix 😄

Edit: So I was right, it was me that had missed something lol.

pickfire pushed a commit that referenced this issue Aug 25, 2022
Changed the `namespace` style to fix the issue (#3533).

I also made the theme look a little closer to how it looks in Emacs, I did however opt to still have it slightly different as I found it easier to read with my port than on the original in Emacs.
I also sorted most keys (mainly from line 8 to 28) for the theme to be in alphabetical order, so it's easier to have a quick glance where they are.
@the-mikedavis
Copy link
Member

Fixed by #3539

AlexanderBrevig pushed a commit to AlexanderBrevig/helix that referenced this issue Aug 29, 2022
Changed the `namespace` style to fix the issue (helix-editor#3533).

I also made the theme look a little closer to how it looks in Emacs, I did however opt to still have it slightly different as I found it easier to read with my port than on the original in Emacs.
I also sorted most keys (mainly from line 8 to 28) for the theme to be in alphabetical order, so it's easier to have a quick glance where they are.
thomasskk pushed a commit to thomasskk/helix that referenced this issue Sep 9, 2022
Changed the `namespace` style to fix the issue (helix-editor#3533).

I also made the theme look a little closer to how it looks in Emacs, I did however opt to still have it slightly different as I found it easier to read with my port than on the original in Emacs.
I also sorted most keys (mainly from line 8 to 28) for the theme to be in alphabetical order, so it's easier to have a quick glance where they are.
jdrst pushed a commit to jdrst/helix that referenced this issue Sep 13, 2022
Changed the `namespace` style to fix the issue (helix-editor#3533).

I also made the theme look a little closer to how it looks in Emacs, I did however opt to still have it slightly different as I found it easier to read with my port than on the original in Emacs.
I also sorted most keys (mainly from line 8 to 28) for the theme to be in alphabetical order, so it's easier to have a quick glance where they are.
herkhinah pushed a commit to herkhinah/helix that referenced this issue Dec 11, 2022
Changed the `namespace` style to fix the issue (helix-editor#3533).

I also made the theme look a little closer to how it looks in Emacs, I did however opt to still have it slightly different as I found it easier to read with my port than on the original in Emacs.
I also sorted most keys (mainly from line 8 to 28) for the theme to be in alphabetical order, so it's easier to have a quick glance where they are.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related C-enhancement Category: Improvements E-good-first-issue Call for participation: Issues suitable for new contributors
Projects
None yet
Development

No branches or pull requests

4 participants