You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have a symlink to the runtime/ in my ~/.config/helix . I wanted to open a theme in runtime/themes inside Helix so I opened the file picker. The symlink showed up but not any files within the actual folder. When I put the pointer on the runtime symlink the preview box says <File not found>. When I press enter on the symlink Helix panics:
thread 'main' panicked at 'editor.open failed: Is a directory (os error 21)', helix-term/src/ui/mod.rs:185:18
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
This doesn't seem very mysterious. I guess following symlinks just isn't implemented yet in the file picker, Helix shouldn't crash because of it though.
Reproduction Steps
I tried this:
Open helix in the config folder.
Open the file picker and select the runtime symlink
I expected this to happen:
Helix would show the files in the folder the symlink points to.
Instead, this happened:
Helix panics.
Helix log
~/.cache/helix/helix.log
These are the latest 10 lines of `helix.log`. Nothing looks relevant.
2022-04-24T11:49:36.554 helix_view::theme [WARN] Theme: invalid style attribute: modifers
2022-04-24T11:49:36.562 helix_view::editor [ERROR] Failed to initialize the LSP for `source.toml` { LSP not defined }
2022-04-24T11:50:09.881 helix_view::theme [WARN] Theme: invalid style attribute: modifers
2022-04-24T11:50:09.881 helix_view::theme [WARN] Theme: invalid style attribute: modifers
2022-04-24T11:50:09.905 helix_view::editor [ERROR] Failed to initialize the LSP for `source.toml` { LSP not defined }
2022-04-24T11:50:49.229 helix_view::theme [WARN] Theme: invalid style attribute: modifers
2022-04-24T11:50:49.230 helix_view::theme [WARN] Theme: invalid style attribute: modifers
2022-04-24T11:50:49.252 helix_view::editor [ERROR] Failed to initialize the LSP for `source.toml` { LSP not defined }
2022-04-24T11:58:26.687 helix_view::theme [WARN] Theme: invalid style attribute: modifers
2022-04-24T11:58:26.687 helix_view::theme [WARN] Theme: invalid style attribute: modifers
Platform
Linux
Terminal Emulator
alacritty
Helix Version
22.03-127-g2c7f770a
The text was updated successfully, but these errors were encountered:
- Add file-picker.follow-symlinks configuration option (default is true), this
also controls if filename and directory completers follow symlinks.
- Update FilePicker to set editor error if opening a file fails, instead of
panicing.
Fixhelix-editor#1548Fixhelix-editor#2246
- Add file-picker.follow-symlinks configuration option (default is true), this
also controls if filename and directory completers follow symlinks.
- Update FilePicker to set editor error if opening a file fails, instead of
panicing.
Fix#1548Fix#2246
- Add file-picker.follow-symlinks configuration option (default is true), this
also controls if filename and directory completers follow symlinks.
- Update FilePicker to set editor error if opening a file fails, instead of
panicing.
Fixhelix-editor#1548Fixhelix-editor#2246
Summary
I have a symlink to the
runtime/
in my~/.config/helix
. I wanted to open a theme inruntime/themes
inside Helix so I opened the file picker. The symlink showed up but not any files within the actual folder. When I put the pointer on the runtime symlink the preview box says<File not found>
. When I press enter on the symlink Helix panics:This doesn't seem very mysterious. I guess following symlinks just isn't implemented yet in the file picker, Helix shouldn't crash because of it though.
Reproduction Steps
I tried this:
I expected this to happen:
Helix would show the files in the folder the symlink points to.
Instead, this happened:
Helix panics.
Helix log
~/.cache/helix/helix.log
These are the latest 10 lines of `helix.log`. Nothing looks relevant.Platform
Linux
Terminal Emulator
alacritty
Helix Version
22.03-127-g2c7f770a
The text was updated successfully, but these errors were encountered: