Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autopair: delete pair on backspace #1673

Closed
tgirod opened this issue Feb 16, 2022 · 3 comments · Fixed by #2940
Closed

autopair: delete pair on backspace #1673

tgirod opened this issue Feb 16, 2022 · 3 comments · Fixed by #2940
Labels
A-core Area: Helix core improvements C-enhancement Category: Improvements

Comments

@tgirod
Copy link

tgirod commented Feb 16, 2022

When in insert mode, autopair gets triggered when a pairable character is entered. But if I press a pairable character by mistake and delete it using backspace, the closing pair is not deleted.

I think it would make more sense to automatically delete the closing character in that situation.

@sudormrfbin
Copy link
Member

There's an open PR: #1379.

@tgirod
Copy link
Author

tgirod commented Feb 16, 2022

good to know, thanks!

@ribosomerocker
Copy link

This should not be closed, should it? Since the issue hasn't been solved yet. It's good to keep it open for people who run into this issue and see no open issues for it, then attempting to make one for it (like me just now). Sorry for the off-topic comment. And also, +1, I guess, since I am commenting on this anyways.

@sudormrfbin sudormrfbin reopened this Apr 11, 2022
@kirawi kirawi added C-enhancement Category: Improvements A-core Area: Helix core improvements labels May 26, 2022
Houkime pushed a commit to Houkime/helix that referenced this issue Jul 2, 2022
archseer pushed a commit that referenced this issue Jul 22, 2022
* auto pair-removal

Fixes #1673

* autopairs removal: use doc autopairs

* autopairs-removal: limit to one-char selections

* use single_grapheme() to check if range is one char

* fix errouneous deletes of " and other symmetric autopairs when at buffer start

Co-authored-by: Houkime <>
thomasskk pushed a commit to thomasskk/helix that referenced this issue Sep 9, 2022
* auto pair-removal

Fixes helix-editor#1673

* autopairs removal: use doc autopairs

* autopairs-removal: limit to one-char selections

* use single_grapheme() to check if range is one char

* fix errouneous deletes of " and other symmetric autopairs when at buffer start

Co-authored-by: Houkime <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Helix core improvements C-enhancement Category: Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants