-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
:goto should not crash if it doesn't input the line number? #1159
Labels
Comments
More info with
|
\cc @s1ck |
wingyplus
added a commit
to wingyplus/helix
that referenced
this issue
Nov 24, 2021
If the user enter `:goto` command without entering a line number, the editor will stay on the current line. Fixes helix-editor#1159
wingyplus
added a commit
to wingyplus/helix
that referenced
this issue
Nov 24, 2021
If the user enter `:goto` command without entering a line number, the editor will stay on the current line. Fixes helix-editor#1159
I opened a PR to be an opinion. Hope this would help. 🙇 |
Thanks for reporting the issue. I can review it later :) |
wingyplus
added a commit
to wingyplus/helix
that referenced
this issue
Nov 24, 2021
Report an error when running goto command without entering a line number. Fixes helix-editor#1159
archseer
pushed a commit
that referenced
this issue
Nov 25, 2021
* Do not crash when run goto command without line number Report an error when running goto command without entering a line number. Fixes #1159 * Use is_empty() instead check len zero
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm not sure is it a bug. The
:goto
command will be panic if I just typing:goto
and enter. The stacktrace is:The text was updated successfully, but these errors were encountered: