only remove when intersecting

helix-editor · Feb 10, 2023 · e5becba · e5becba
1 parent 4ca0c93
commit e5becba
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/helix-term/src/commands.rs b/helix-term/src/commands.rs
@@ -4086,7 +4086,8 @@ pub fn completion(cx: &mut Context) {
                     trigger_offset,
                     size,
                 )
-                .and_then(|area| Some(area.intersects(signature_help_area?)))
+                .zip(signature_help_area)
+                .filter(|(a, b)| a.intersects(*b))
                 .is_some()
             {
                 compositor.remove(SignatureHelp::ID);

diff --git a/helix-term/src/ui/editor.rs b/helix-term/src/ui/editor.rs
@@ -1372,7 +1372,7 @@ impl Component for EditorView {
                                         // assume close_fn
                                         self.clear_completion(cx.editor);
 
-                                        // In case the popup was deleted beacuse of an intersection w/ the auto-complete menu.
+                                        // In case the popup was deleted because of an intersection w/ the auto-complete menu.
                                         commands::signature_help_impl(
                                             &mut cx,
                                             commands::SignatureHelpInvoked::Automatic,