fix ci

helix-editor · Jul 31, 2024 · c80b4d7 · c80b4d7
1 parent 248694b
commit c80b4d7
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/helix-stdx/src/faccess.rs b/helix-stdx/src/faccess.rs
@@ -97,7 +97,9 @@ mod imp {
 #[cfg(windows)]
 mod imp {
 
-    use windows_sys::Win32::Foundation::{CloseHandle, LocalFree, ERROR_SUCCESS, HANDLE, PSID};
+    use windows_sys::Win32::Foundation::{
+        CloseHandle, LocalFree, ERROR_SUCCESS, GENERIC_READ, GENERIC_WRITE, HANDLE, PSID,
+    };
     use windows_sys::Win32::Security::Authorization::{
         GetNamedSecurityInfoW, SetSecurityInfo, SE_FILE_OBJECT,
     };
@@ -112,7 +114,8 @@ mod imp {
     };
     use windows_sys::Win32::Storage::FileSystem::{
         GetFileInformationByHandle, BY_HANDLE_FILE_INFORMATION, FILE_ACCESS_RIGHTS,
-        FILE_ALL_ACCESS, FILE_GENERIC_EXECUTE, FILE_GENERIC_READ, FILE_GENERIC_WRITE,
+        FILE_ALL_ACCESS, FILE_GENERIC_EXECUTE, FILE_GENERIC_READ, FILE_GENERIC_WRITE, WRITE_DAC,
+        WRITE_OWNER,
     };
     use windows_sys::Win32::System::Threading::{GetCurrentThread, OpenThreadToken};
 
@@ -450,9 +453,12 @@ mod imp {
 
     pub fn create_copy_mode(from: &Path, to: &Path) -> io::Result<File> {
         let sd = SecurityDescriptor::for_path(from)?;
+
+        // read/write still need to be set to true or `create_new` returns an error
         let to_file = std::fs::OpenOptions::new()
             .read(true)
             .write(true)
+            .access_mode(GENERIC_READ | GENERIC_WRITE | WRITE_OWNER | WRITE_DAC)
             .create_new(true)
             .open(to)?;