Skip to content

Commit

Permalink
Fix diagnostic indicator background for gruvbox themes (#5540)
Browse files Browse the repository at this point in the history
The diagnostic indicator background did not match the column or rows background
colour as this was context specific, and the background for the indicator was
being explicitly set.

This commit removes the explicit value for the indicators background allowing
it to adapt to the context. This is aligns it with other themes, and resolves
the issue.
  • Loading branch information
joshbainbridge authored Jan 17, 2023
1 parent e7e47fd commit b65f104
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 12 deletions.
8 changes: 4 additions & 4 deletions runtime/themes/gruvbox.toml
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@
"diff.delta" = "orange1"
"diff.minus" = "red1"

"warning" = { fg = "orange1", bg = "bg1" }
"error" = { fg = "red1", bg = "bg1" }
"info" = { fg = "aqua1", bg = "bg1" }
"hint" = { fg = "blue1", bg = "bg1" }
"warning" = "orange1"
"error" = "red1"
"info" = "aqua1"
"hint" = "blue1"

"ui.background" = { bg = "bg0" }
"ui.linenr" = { fg = "bg4" }
Expand Down
8 changes: 4 additions & 4 deletions runtime/themes/gruvbox_dark_hard.toml
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@
"diff.delta" = "orange1"
"diff.minus" = "red1"

"warning" = { fg = "orange1", bg = "bg1" }
"error" = { fg = "red1", bg = "bg1" }
"info" = { fg = "aqua1", bg = "bg1" }
"hint" = { fg = "blue1", bg = "bg1" }
"warning" = "orange1"
"error" = "red1"
"info" = "aqua1"
"hint" = "blue1"

"diagnostic.error" = { underline = { style = "curl", color = "red0" } }
"diagnostic.warning" = { underline = { style = "curl", color = "orange1" } }
Expand Down
8 changes: 4 additions & 4 deletions runtime/themes/gruvbox_light.toml
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@
"diff.delta" = "orange1"
"diff.minus" = "red1"

"warning" = { fg = "orange1", bg = "bg1" }
"error" = { fg = "red1", bg = "bg1" }
"info" = { fg = "aqua1", bg = "bg1" }
"hint" = { fg = "blue1", bg = "bg1" }
"warning" = "orange1"
"error" = "red1"
"info" = "aqua1"
"hint" = "blue1"

"ui.background" = { bg = "bg0" }
"ui.linenr" = { fg = "bg4" }
Expand Down

0 comments on commit b65f104

Please sign in to comment.