-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
separate JSX queries from javascript
It looks like a24fb17 (and 855e438) broke the typescript highlights because typescript ; inherits: javascript but it doesn't have those named nodes in its grammar. So instead we can separate out JSX into its own language and copy over everything from javascript and supplement it with the new JSX highlights. Luckily there isn't too much duplication, just the language configuration parts - we can re-use the parser with the languages.toml `grammar` key and most of the queries with `inherits`.
- Loading branch information
1 parent
deb7ee6
commit 0482552
Showing
6 changed files
with
41 additions
and
30 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
; inherits: javascript | ||
|
||
; Highlight component names differently | ||
(jsx_opening_element ((identifier) @constructor | ||
(#match? @constructor "^[A-Z]"))) | ||
|
||
; Handle the dot operator effectively - <My.Component> | ||
(jsx_opening_element ((nested_identifier (identifier) @tag (identifier) @constructor))) | ||
|
||
(jsx_closing_element ((identifier) @constructor | ||
(#match? @constructor "^[A-Z]"))) | ||
|
||
; Handle the dot operator effectively - </My.Component> | ||
(jsx_closing_element ((nested_identifier (identifier) @tag (identifier) @constructor))) | ||
|
||
(jsx_self_closing_element ((identifier) @constructor | ||
(#match? @constructor "^[A-Z]"))) | ||
|
||
; Handle the dot operator effectively - <My.Component /> | ||
(jsx_self_closing_element ((nested_identifier (identifier) @tag (identifier) @constructor))) | ||
|
||
; TODO: also tag @punctuation.delimiter? | ||
|
||
(jsx_opening_element (identifier) @tag) | ||
(jsx_closing_element (identifier) @tag) | ||
(jsx_self_closing_element (identifier) @tag) | ||
(jsx_attribute (property_identifier) @variable.other.member) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
; inherits: javascript |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
; inherits: javascript |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
; inherits: javascript |