Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instruction error serialization 0.2.1 #88

Conversation

levicook
Copy link
Contributor

@levicook levicook commented Nov 4, 2024

Fixes

Failed to parse transactions for signatures, error: SerdeJson(Error("missing field `InstructionError`", ...))

Encountered when calling helius::Helius.parse_transactions ala:

        match state.helius.parse_transactions(req).await {
            Ok(transactions) => {
                for transaction in transactions {
                    crate::enhanced_transactions::ingest_essentials(&state, transaction).await?;
                }
            }

@levicook
Copy link
Contributor Author

levicook commented Nov 4, 2024

@0xIchigo -- I just patched the release version I was locked into. No idea if this was fixed later, so consider this draft an FYI.

@levicook
Copy link
Contributor Author

levicook commented Nov 4, 2024

also noticed that instruciton_error is misspelled after looking at it a hundred other times.

@0xIchigo
Copy link
Collaborator

0xIchigo commented Nov 4, 2024

@levicook nice catch! This hasn't been fixed yet, so feel free to mark the PR as ready for review. Also, feel free to update the spelling of instruction_error

@levicook levicook marked this pull request as ready for review November 4, 2024 21:28
@levicook
Copy link
Contributor Author

levicook commented Nov 4, 2024

sounds good! corrected the typo & marked ready for review. :shipit:

Copy link
Collaborator

@0xIchigo 0xIchigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based 🔥

@0xIchigo 0xIchigo merged commit d09cf7a into helius-labs:dev Nov 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants