include attestation data in receipt and witness reports #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andymck
force-pushed
the
andymck/poc-grpc
branch
2 times, most recently
from
51df619 to
c88928d
Compare
madninja
force-pushed
the
andymck/poc-grpc
branch
from
e518827 to
6d12141
Compare
andymck
force-pushed
the
andymck/poc-grpc-report-attestation
branch
from
9643884 to
ff36c41
Compare
madninja
reviewed
Apr 28, 2022
| message attestation { | ||
| uint64 height = 1; | ||
| uint64 block_time = 2; | ||
| uint64 block_age = 3; |
There was a problem hiding this comment.
how is block_age being used here?
andymck
force-pushed
the
andymck/poc-grpc-report-attestation
branch
from
e7ff7ae to
ee4e5b9
Compare
andymck
force-pushed
the
andymck/poc-grpc-report-attestation
branch
from
068e4fc to
4579269
Compare
|
can we close this @andymck ? |
|
yeah unlikely this is going to go anywhere now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proto side of helium/miner#1481