-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support wifi heartbeats originating from indoor wifi hotspots #623
Conversation
b17e7aa
to
0c66e99
Compare
fadd3b6
to
27bbd18
Compare
1e48638
to
bc575b4
Compare
df3fe4c
to
994d0fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renaming heartbeats to heartbeats_util and wifi_heartbeats seems like a pretty drastic and non-idiomatic change. If you'd like to split that file up, I recommend creating a heartbeats directory, putting the "util" contents into the mod.rs
, and the wifi contents into wifi.rs
module
da55c18
to
6e8c771
Compare
to clarify, heartbeats was broken up into 3 modules. cbrs_heartbeats, wifi_heartbeats and then a shared module heartbeats_util. I do like the approach of adding a heartbeats directory which then containts cbrs, wifi and then a mod.util and will change to that |
Ah nevermind ^ I see that's what you did. Great! |
293cdee
to
db7aacd
Compare
3116752
to
60f2542
Compare
f45d5c8
to
32e5344
Compare
Provides support for the ingestion, processing & rewarding of wifi heartbeats
Linked proto pr: helium/proto#364