testing without helium lib as a dep of mobile config

helium · Dec 20, 2024 · 44ea4af · 44ea4af
1 parent 9c48ec4
commit 44ea4af
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 9 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/mobile_config/Cargo.toml b/mobile_config/Cargo.toml
@@ -22,7 +22,6 @@ file-store = { path = "../file_store" }
 futures = { workspace = true }
 futures-util = { workspace = true }
 helium-crypto = { workspace = true, features = ["sqlx-postgres"] }
-helium-lib = { workspace = true }
 helium-proto = { workspace = true }
 humantime = { workspace = true }
 humantime-serde = { workspace = true }

diff --git a/mobile_config/src/client/sub_dao_client.rs b/mobile_config/src/client/sub_dao_client.rs
@@ -2,7 +2,6 @@ use super::{call_with_retry, ClientError, Settings};
 use crate::sub_dao_epoch_reward_info::EpochRewardInfo;
 use file_store::traits::MsgVerify;
 use helium_crypto::{Keypair, PublicKey, Sign};
-use helium_lib::keypair::Pubkey;
 use helium_proto::{
     services::{
         sub_dao::{self, SubDaoEpochRewardInfoReqV1},
@@ -35,7 +34,7 @@ pub trait SubDaoEpochRewardInfoResolver: Clone + Send + Sync + 'static {
 
     async fn resolve_info(
         &self,
-        sub_dao: &Pubkey,
+        sub_dao: &str,
         epoch: u64,
     ) -> Result<Option<EpochRewardInfo>, Self::Error>;
 }
@@ -46,7 +45,7 @@ impl SubDaoEpochRewardInfoResolver for SubDaoClient {
 
     async fn resolve_info(
         &self,
-        sub_dao: &Pubkey,
+        sub_dao: &str,
         epoch: u64,
     ) -> Result<Option<EpochRewardInfo>, Self::Error> {
         let mut request = SubDaoEpochRewardInfoReqV1 {

diff --git a/mobile_verifier/src/cli/reward_from_db.rs b/mobile_verifier/src/cli/reward_from_db.rs
@@ -36,7 +36,7 @@ impl Cmd {
         let sub_dao = resolve_subdao_pubkey();
 
         let reward_info = sub_dao_rewards_client
-            .resolve_info(&sub_dao, reward_epoch)
+            .resolve_info(&sub_dao.to_string(), reward_epoch)
             .await?
             .ok_or(anyhow::anyhow!(
                 "No reward info found for epoch {}",

diff --git a/mobile_verifier/src/rewarder.rs b/mobile_verifier/src/rewarder.rs
@@ -251,7 +251,7 @@ where
     pub async fn reward(&self, next_reward_epoch: u64) -> anyhow::Result<()> {
         let reward_info = self
             .sub_dao_epoch_reward_client
-            .resolve_info(&self.sub_dao, next_reward_epoch)
+            .resolve_info(&self.sub_dao.to_string(), next_reward_epoch)
             .await?
             .ok_or(anyhow::anyhow!(
                 "No reward info found for epoch {}",

diff --git a/mobile_verifier/tests/integrations/common/mod.rs b/mobile_verifier/tests/integrations/common/mod.rs
@@ -5,7 +5,6 @@ use file_store::{
 };
 use futures::{stream, StreamExt};
 use helium_crypto::PublicKeyBinary;
-use helium_lib::keypair::Pubkey;
 use helium_lib::token::Token;
 use helium_proto::services::{
     mobile_config::NetworkKeyRole,
@@ -80,7 +79,7 @@ impl SubDaoEpochRewardInfoResolver for MockSubDaoRewardsClient {
 
     async fn resolve_info(
         &self,
-        _sub_dao: &Pubkey,
+        _sub_dao: &str,
         _epoch: u64,
     ) -> Result<Option<EpochRewardInfo>, Self::Error> {
         Ok(self.info.clone())