This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
Fix jsonrpc ledger balance for entry v2 #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vihu
reviewed
Sep 30, 2022
| <<"balance">> => blockchain_ledger_entry_v1:balance(Entry) | ||
| }. | ||
| format_ledger_balance(Addr, Entry, Ledger) -> | ||
| case blockchain_ledger_v1:config(token_version, Ledger) of |
There was a problem hiding this comment.
You could call blockchain_ledger_v1:versioned_entry_mod_and_entries_cf/1 and not have to do the token_version check here by hand. So this function can be reduced to something like this:
{EntryMod, _} = blockchain_ledger_v1:versioned_entry_mod_and_entries_cf(Ledger),
#{<<"nonce">> = EntryMod:nonce(Entry), ...} 
Vagabond
approved these changes
Sep 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the JSONRPC call for account balances to use ledger entry v2 when the token_version is set to 2 (or higher). This allows the JSONRPC call to continue to pull current balance since the MOBILE / subnetworks went were activated.