This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
add ability to not gossip with miners #1804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would using <<"node_type">> not be a better option to check here ? Which would have a value of <<"gateway">> for miners ? |
jadeallenx
approved these changes
Aug 17, 2022
Vagabond
approved these changes
Aug 17, 2022
This was referenced Aug 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since the miner stopped following the chain, not connecting to them blackholes a gossip link, making it hard for certain nodes to connect to active chain followers and stay synced. this PR makes prefer non-miners as gossip peers, hopefully improving sync until we can remove the miners from the gossip network, at which point we can tune down the number of active connections.