This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
improve validator build ux #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadeallenx
reviewed
Aug 27, 2021
| @@ -11,8 +11,10 @@ MINER_REGISTRY_NAME="$REGISTRY_HOST/team-helium/$REGISTRY_NAME" | |||
| DOCKER_NAME="$(basename $(pwd))-${IMAGE_ARCH}_testnet_${BUILDKITE_TAG}" | |||
| DOCKERFILE_NAME=".buildkite/scripts/Dockerfile-testval-${IMAGE_ARCH}" | |||
|
|
|||
| VERSION=$(git describe --abbrev=0 | sed -e 's,validator,,') | |||
There was a problem hiding this comment.
IIRC this tag is just val not all spelled out, right?
There was a problem hiding this comment.
val is for testnet, validator is for mainnet, I am a terrible hack
|
lgtm 👍 |
jadeallenx
approved these changes
Aug 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebar3's versioning leaves something to be desired at present and we don't have the resources to fix it ourselves right now. this should make working around it a bit easier.