Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react native crypto update #1324

Merged
merged 7 commits into from
Jul 1, 2022
Merged

react native crypto update #1324

merged 7 commits into from
Jul 1, 2022

Conversation

tyler-whitman
Copy link
Contributor

@tyler-whitman tyler-whitman commented Jun 29, 2022

  • resolves invalid 0000 checksum issue when creating an account. New accounts will now be created with proper checksums. Existing accounts with 0000 checksums can still be imported.
  • updates all the @helium libraries to the latest

Copy link
Contributor

@Perronef5 Perronef5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Need to test locally

  • Peroni test

@Perronef5
Copy link
Contributor

LGTM. Need to test locally

  • Peroni test

Tested and Looks good. Was able to import account with 12 words and proper checksum.

@helium helium deleted a comment from chris10an2022 Jul 1, 2022
@tyler-whitman tyler-whitman merged commit afbe334 into main Jul 1, 2022
@tyler-whitman tyler-whitman deleted the feat/crypto_update branch July 1, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants