Fix OTel extract when there is no current context #8578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Quinn <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
ljnelson
reviewed
Mar 28, 2024
| @Test | ||
| void testExtractWithNoCurrentSpan() { | ||
| final String BAGGAGE_KEY = "mykey"; | ||
| final String BAGGAGE_VALUE = "myvalue"; |
ljnelson
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #8573
The Helidon
OpenTelemetryTracerclassextractmethod (which creates aSpanContextfrom headers) incorrectly returned a no-opSpanContextif there was no current span, rather than the documentedOptional.empty().This PR fixes that by trying to construct an OTel
Spanfirst from the context, and only if that yields a span go ahead and return the span context.The PR also adds a test for this and fixes an earlier test that did not supply enough headers for OTel to fully constitute a valid span.
Documentation
Bug fix; no doc impact