Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect named port selection in MicrometerSupport for endpoint #8518

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

tjquinno
Copy link
Member

@tjquinno tjquinno commented Mar 22, 2024

Description

Resolves #8517

The MicrometerSupport object uses the configured settings for web-context and routing but applied them to the routing for normal application endpoints, not for the service routing as it should have.

This PR corrects that, setting the endpoint and routing on the service routing instead.

Documentation

No impact.

@tjquinno tjquinno self-assigned this Mar 22, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 22, 2024
Copy link
Member

@spericas spericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjquinno tjquinno merged commit 4397854 into helidon-io:helidon-3.x Mar 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants