[4.x] Set weight for WebClientTracing provider greater than that for WebClientSecurity provider
#8274
+63
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
spericas
approved these changes
Jan 22, 2024
…entSecurity provider; security needs to have the span context set before it runs Signed-off-by: Tim Quinn <[email protected]>
tjquinno
force-pushed
the
4.x-webclient-tracing-security
branch
from
885ff0d to
217f578
Compare
barchetta
approved these changes
Jan 22, 2024
hrstoyanov
pushed a commit
to hrstoyanov/helidon
that referenced
this pull request
Feb 23, 2024
…r `WebClientSecurity` provider (helidon-io#8274) * Set weight for WebClientTracing provider greater than that for WebClientSecurity provider; security needs to have the span context set before it runs Signed-off-by: Tim Quinn <[email protected]> * Add test for service provider weights --------- Signed-off-by: Tim Quinn <[email protected]>
tvallin
pushed a commit
to tvallin/helidon
that referenced
this pull request
Feb 28, 2024
…r `WebClientSecurity` provider (helidon-io#8274) * Set weight for WebClientTracing provider greater than that for WebClientSecurity provider; security needs to have the span context set before it runs Signed-off-by: Tim Quinn <[email protected]> * Add test for service provider weights --------- Signed-off-by: Tim Quinn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Likely/possibly resolves #8192
Assign an explicit weight to
WebClientTracingProviderthat is greater than the weight forWebClientSecurityProvider(which is the default). This makes sure that Helidon invokesWebClientTracing#handlebeforeWebClientSecurity#handle. The latter depends on the request context containing span information which is set byWebClientTracing#handle.With no explicit weight set, the order of execution is indeterminate and could create the kind of failure noted in the issue.
(I tried creating a simple test but, because without explicit weighting the order is indeterminate, the test passed even without the fix because the order just happened to be the order that works: tracing, then security. So the PR contains no test.)
Documentation
bug fix; no doc impact