Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix premature access to RegistryFactory #8118

Merged
merged 5 commits into from
Dec 11, 2023
Merged

Fix premature access to RegistryFactory #8118

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
db76539
Test premature access to RegistryFactory
tjquinno Dec 8, 2023
4e74d6c
Two updates to test further
tjquinno Dec 8, 2023
d11a9b5
Try undoing the change to see if that fixes pipeline failures
tjquinno Dec 9, 2023
4de342b
Later priority than metrics again
tjquinno Dec 9, 2023
b45cb9b
Make permanent change to JpaExtension priority
tjquinno Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions integrations/cdi/jpa-cdi/src/main/java/io/helidon/integrations/cdi/jpa/JpaExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,7 +804,7 @@ private <T extends EntityManager> void saveEntityManagerQualifiers(@Observes
* @exception IOException if an input or output error occurs, typically because a {@code META-INF/persistence.xml}
* resource was found but could not be loaded for some reason
*
* @exception JAXBException if there was a problem {@linkplain Unmarshaller#unmarshal(Reader) unmarshalling} a
* @exception JAXBException if there was a problem {@linkplain Unmarshaller#unmarshal(java.io.Reader) unmarshalling} a
* {@code META-INF/persistence.xml} resource
*
* @exception NullPointerException if either {@code event} or {@code beanManager} is {@code null}
Expand Down Expand Up @@ -2045,7 +2045,7 @@ private void maybeAddPersistenceProviderBean(AfterBeanDiscovery event,

private void onStartup(@Observes
@Initialized(ApplicationScoped.class)
@Priority(LIBRARY_BEFORE)
@Priority(LIBRARY_BEFORE + 20) // Must be later than metrics CDI extension priority
Object event,
@ContainerManaged
Instance<EntityManagerFactory> emfs) {
Expand Down