Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.x] - MP OpenTelemetry and Helidon Tracing API #8073

Merged
merged 18 commits into from
Dec 1, 2023
Merged

[4.x] - MP OpenTelemetry and Helidon Tracing API #8073

merged 18 commits into from
Dec 1, 2023

Conversation

dalexandrov
Copy link
Contributor

@dalexandrov dalexandrov commented Nov 24, 2023 •
edited
Loading

Resolves #8068

  • add `io.helidon.tracing.Tracer' injection
  • register Global telemetry object
  • add full URL span name property
  • correct mix of Helidon Tracing API and OpenTelemetry API with the correct parent setting
  • documentation

@dalexandrov
Initial fix
99c45a0 
Signed-off-by: Dmitry Aleksandrov <[email protected]>
@dalexandrov
Refactor, add full url in span name support
8957b77 
Signed-off-by: Dmitry Aleksandrov <[email protected]>
@dalexandrov
Checkstyle fixes
20008fa 
Signed-off-by: Dmitry Aleksandrov <[email protected]>
@dalexandrov dalexandrov added this to the 4.0.2 milestone Nov 24, 2023
@dalexandrov dalexandrov self-assigned this Nov 24, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 24, 2023
@dalexandrov
Add arquillian test
fdcbd3e 
Signed-off-by: Dmitry Aleksandrov <[email protected]>
@dalexandrov
Hierarchy test
0547cd1 
Signed-off-by: Dmitry Aleksandrov <[email protected]>
@dalexandrov
Clean up
28f209b 
Signed-off-by: Dmitry Aleksandrov <[email protected]>
@dalexandrov
Document
b31b9fc 
Signed-off-by: Dmitry Aleksandrov <[email protected]>
@dalexandrov
Correct Helidon Tracing API set up in case of Agent
0b9ea1d 
Signed-off-by: Dmitry Aleksandrov <[email protected]>
@dalexandrov dalexandrov marked this pull request as ready for review November 27, 2023 13:28
@dalexandrov
Minor fix
197448b 
Signed-off-by: Dmitry Aleksandrov <[email protected]>
tomas-langer
tomas-langer requested changes Nov 29, 2023
View reviewed changes
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the example

@dalexandrov
Extend timeout
d3a862d 
Signed-off-by: Dmitry Aleksandrov <[email protected]>
@dalexandrov
Extend timeout
5793ebe 
Signed-off-by: Dmitry Aleksandrov <[email protected]>
@dalexandrov
Refactor URL
1069474 
Signed-off-by: Dmitry Aleksandrov <[email protected]>
tomas-langer
tomas-langer requested changes Nov 30, 2023
View reviewed changes
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not want (and need) to use Arquillian.
We just need to create a tracer in memory, and register it with open telemetry, so it can be accessed later from tests.

...e/tests/telemetry/src/test/java/io/helidon/microprofile/telemetry/RestSpanHierarchyTest.java Outdated
/**
* Test Span Hierarchy with Tracer Mock
*/
@ExtendWith(ArquillianExtension.class)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely do not want to use Arquillian in Helidon tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@dalexandrov
Remove arquillian
8d2cc72 
Signed-off-by: Dmitry Aleksandrov <[email protected]>
@dalexandrov
Clean up
9e83c39 
Signed-off-by: Dmitry Aleksandrov <[email protected]>
@dalexandrov
Clean up
69c1d4e 
Signed-off-by: Dmitry Aleksandrov <[email protected]>
@dalexandrov
Clean up
f90ac28 
Signed-off-by: Dmitry Aleksandrov <[email protected]>
@dalexandrov dalexandrov merged commit a5764d1 into helidon-io:main Dec 1, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-langer tomas-langer tomas-langer approved these changes

Assignees

@dalexandrov dalexandrov

Labels
4.x Version 4.x microprofile OCA Verified All contributors have signed the Oracle Contributor Agreement. telemetry tracing
Projects
None yet
Milestone
4.0.2
Development

Successfully merging this pull request may close these issues.

[Epic] Opentelemetry and Helidon Tracing API in Helidon 4
2 participants
@dalexandrov @tomas-langer