[4.x] Adds a DialectFactory implementation to permit Hibernate to introspect database metadata properly when supporting container-mode JPA #7927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t database metadata properly when supporting container-mode JPA Signed-off-by: Laird Nelson <[email protected]>
ljnelson
added
enhancement
oracle-contributor-agreement
bot
added
the
OCA Verified
ljnelson
changed the title
Signed-off-by: Laird Nelson <[email protected]>
…an function in pathological environments Signed-off-by: Laird Nelson <[email protected]>
|
@barchetta I've tagged you mainly to take a look at the javadoc work (Hibernate didn't have an |
Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
tjquinno
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
DialectFactoryimplementation that can introspect aDataSource-reachableDatabaseMetaDatato discover and build the properDialectfor Hibernate to use to communicate with a database.The
DialectFactoryimplementation is needed because Hibernate's defaultDialectFactoryimplementation is incapable of discovering database connectivity information that is indirectly linked by aMETA-INF/persistence.xml's<jta-data-source>element. (The default Hibernate behavior relies on an application-mode-JPA-only property that, interestingly, the specification rightly discourages users from providing when using container-mode JPA.)The
DataSourceBackedDialectFactorydetects the case when theDialectResolutionInfoSourcesupplied to theDialectFactory'sbuildDialect()method isnull. (The possibility of its beingnullis not documented, but it is very commonlynullin almost all situations.) When this state of affairs holds, theDataSourceBackedDialectFactorywill get its hands on aDatabaseMetaDataand build a properDialectResolutionInfoSourcerepresenting it. It will then hand this off to an invocation of the defaultDialectFactoryimplementation'sbuildDialect()method.The net result is that dialect introspection happens properly even when the only way that Hibernate can "see" the database is by way of a JTA data source.
The other methods in the class are related to actually getting it recognized by Hibernate's convoluted bootstrap sequencing. Notably, the
DialectFactoryimplementation will not register itself if the user has specified aDialectexplicitly.This PR also ensures that Hibernate javadoc is correctly linked.
This PR also ensures that the existing
CDISEJtaPlatformProviderclass functions properly even when CDI is not present.